improvement: upgrade typescript and target #10676
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tsconfig.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "target": "es5", | |||
| "target": "ESNext", | |||
There was a problem hiding this comment.
The justification you provide for this change:
The target has been changed in the tsconfig.json file from "es5" to "ESNext". This allows us to use modern JavaScript features, making the code cleaner and more efficient.
Is pretty unclear. Which features? What's cleaner? What's more efficient? The target option impacts the final build. As per the docs:
Modern browsers support all ES6 features, so ES6 is a good choice. You might choose to set a lower target if your code is deployed to older environments, or a higher target if your code is guaranteed to run in newer environments.
The target setting changes which JS features are downleveled and which are left intact. For example, an arrow function () => this will be turned into an equivalent function expression if target is ES5 or lower.
Changing target also changes the default value of lib. You may “mix and match” target and lib settings as desired, but you could just set target for convenience.
For developer platforms like Node there are baselines for the target, depending on the type of platform and its version. You can find a set of community organized TSConfigs at tsconfig/bases, which has configurations for common platforms and their versions.
The special ESNext value refers to the highest version your version of TypeScript supports. This setting should be used with caution, since it doesn’t mean the same thing between different TypeScript versions and can make upgrades less predictable.
So this change introduces a risk of breaking the website for older browser. If we ever do it, there must be a good justification and it must be properly tested for regressions.
| "target": "ESNext", | |
| "target": "es5", |
Upgrade TypeScript from version 5.3.2 to 5.6.2 and change TypeScript target to “ESNext”
This PR enhances our project by upgrading TypeScript from version 5.3.2 to 5.6.2. This update allows us to take advantage of the latest features, optimizations, and bug fixes provided by TypeScript.
Changes Made
TypeScript Upgrade:
TypeScript has been updated from 5.3.2 to 5.6.2. This includes several performance improvements and new features, such as support for named capturing groups and type enhancements.
Type Errors Correction:
All type errors introduced by this update have been fixed to ensure compatibility and maintain code quality.
TypeScript Target Change:
The target has been changed in the tsconfig.json file from "es5" to "ESNext". This allows us to use modern JavaScript features, making the code cleaner and more efficient.