add scroll to top button

[bintus-ux]

Fix for issue number #5310

Desktop View

Mobile View

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: bintus-ux / name: Ezerike Caleb Chikere (9577652, e96665d, 55422f0, 6ffa8bf, abf7189, 3214531, 77bc340, 78146e6, 2decbe2, 0c7af1e, 4f80e5f, f721bee, 6b172dc, d954b07, 7abaa9a, 1c63e6e, 809781c, ddb416e, 55a83b6, 00244a0, 4be5cce, 9e94417, 64a675d, 97bd65b, 0ad8f06, 7965ddf, fa1437f, b69e316, 4959ae5, b15841d, 634895e, 56ffcca, d361410, 274b700, a0219f9, 3a5a396, 50035a7, 39c0d50, d22d89e, 7dbfc28, de39020, c8e93f7, 5b8dae9, 0274e4e)
• ✅ login: svrnm / name: Severin Neumann (9510a79)

[bintus-ux]

@svrnm could you please test and review

[svrnm]

great start, some inline feedback for you to address.

[bintus-ux]

@svrnm Issues have been resolved , please kindly review once again.

[svrnm]

Can you see if it is possible to make sure that the button "stops" above the page footer when scrolling down?

[bintus-ux]

On Wed, 9 Oct 2024 at 10:03 AM Severin Neumann ***@***.***> wrote: Screenshot.2024-10-09.at.11.00.14.png (view on web) <https://github.com/user-attachments/assets/0e0bc8ed-b956-4a5e-ac2f-fbe2a31f83bc> Can you see if it is possible to make sure that the button "stops" above the page footer when scrolling down? — Reply to this email directly, view it on GitHub <#5331 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A5F4OZ5EQ6IOBIN55OAASSTZ2TWOFAVCNFSM6AAAAABPNR34GSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBRG42TINBYGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Noted. On it.

[bintus-ux]

Hello @svrnm , i might need your help please, appears i might have broken deploy by trying to access submodule themes/docsy to reach the footer.html file , please how do i resolve, thanks.

[svrnm]

Hello @svrnm , i might need your help please, appears i might have broken deploy by trying to access submodule themes/docsy to reach the footer.html file , please how do i resolve, thanks.

Run npm run fix:submodule locally this should restore the right versions of your code. Note that you should never touch into the docsy code. If there is any blocker to roll this out across the website we can still start with the registry and see later how and where we want to have it as well.

[bintus-ux]

Hello @svrnm , i might need your help please, appears i might have broken deploy by trying to access submodule themes/docsy to reach the footer.html file , please how do i resolve, thanks.

Run npm run fix:submodule locally this should restore the right versions of your code. Note that you should never touch into the docsy code. If there is any blocker to roll this out across the website we can still start with the registry and see later how and where we want to have it as well.

I don’t know if it’s a blocker as in order to access the footer.html file which is where I could implement the scroll-to-top to effect on the website it resulted in the issue accessing themes/docsy

[bintus-ux]

Hello @svrnm , i might need your help please, appears i might have broken deploy by trying to access submodule themes/docsy to reach the footer.html file , please how do i resolve, thanks.

Run npm run fix:submodule locally this should restore the right versions of your code. Note that you should never touch into the docsy code. If there is any blocker to roll this out across the website we can still start with the registry and see later how and where we want to have it as well.

I don’t know if it’s a blocker as in order to access the footer.html file which is where I could implement the scroll-to-top to effect on the website it resulted in the issue accessing themes/docsy

I’ve run the command and pushed my changes but the deploy checks don’t re-run @svrnm

[svrnm]

Hello @svrnm , i might need your help please, appears i might have broken deploy by trying to access submodule themes/docsy to reach the footer.html file , please how do i resolve, thanks.

Run npm run fix:submodule locally this should restore the right versions of your code. Note that you should never touch into the docsy code. If there is any blocker to roll this out across the website we can still start with the registry and see later how and where we want to have it as well.

I don’t know if it’s a blocker as in order to access the footer.html file which is where I could implement the scroll-to-top to effect on the website it resulted in the issue accessing themes/docsy

I’ve run the command and pushed my changes but the deploy checks don’t re-run @svrnm

your submodules are still broken, we can try to get it fixed via a bot

[svrnm]

/fix:submodule

[opentelemetrybot]

You triggered fix:submodule action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11818050526

[opentelemetrybot]

fix:submodule failed or was cancelled. For details, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/11818050526.

[bintus-ux]

I am super sorry if i broke something.

[svrnm]

I am super sorry if i broke something.

you didn't. Submodules are challenging from time to time, that's why we have some helpers to fix issues with them.

I pulled your PR and fixed it locally on my end. Make sure you run "git pull" on your end before doing any more changes

[bintus-ux]

I am super sorry if i broke something.

you didn't. Submodules are challenging from time to time, that's why we have some helpers to fix issues with them.

I pulled your PR and fixed it locally on my end. Make sure you run "git pull" on your end before doing any more changes

Appreciate so much, thanks!!!

[bintus-ux]

@svrnm I pulled your changes as you said, ran the npm run fix:format and merged with main. Deployment fails as i am already done with my scroll-to-top changes

[svrnm]

@bintus-ux there seems to be something broken in the PR and the git commit history, I tried to rebase it but I get a lot of merge conflicts that are hard to resolve. Please do the following:

• Backup your local version of this PR and the cloned repo
• Go to https://github.com/bintus-ux/opentelemetry.io/ and make sure that it is in sync with upstream
• Clone your fork freshly
• Copy your changes from the backup into your freshly cloned directory
• Run npm run fix:all
• Create a new branch
• Push that new branch into a new PR

If that new PR has everything we need we can close down this one

[bintus-ux]

@bintus-ux there seems to be something broken in the PR and the git commit history, I tried to rebase it but I get a lot of merge conflicts that are hard to resolve. Please do the following:

• Backup your local version of this PR and the cloned repo
• Go to https://github.com/bintus-ux/opentelemetry.io/ and make sure that it is in sync with upstream
• Clone your fork freshly
• Copy your changes from the backup into your freshly cloned directory
• Run npm run fix:all
• Create a new branch
• Push that new branch into a new PR

If that new PR has everything we need we can close down this one

Appears the best solution, will do that now, thank you.

[bintus-ux]

Sorry to still be dwelling on this issue, i did as you said, my fork was in sync with upstream before i recloned it,manually copied my changes into the codebase and ran npm run fix:all which popped up this clone errors for opentelemetry-go @svrnm

[svrnm]

Sorry to still be dwelling on this issue, i did as you said, my fork was in sync with upstream before i recloned it,manually copied my changes into the codebase and ran npm run fix:all which popped up this clone errors for opentelemetry-go @svrnm

can you delete that folder and try it once again?

[bintus-ux]

Sorry to still be dwelling on this issue, i did as you said, my fork was in sync with upstream before i recloned it,manually copied my changes into the codebase and ran npm run fix:all which popped up this clone errors for opentelemetry-go @svrnm

can you delete that folder and try it once again?

Hello mentor, successfully made a new pr #5620 for the scroll to top functionality. Appreciate your efforts and guidance so far, thanks so much mentor @svrnm !