Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs API to have functionality for reusing Standard Attributes #4373

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ release.
([#4352](https://github.com/open-telemetry/opentelemetry-specification/pull/4352))
- Make all `Logger` operations user-facing.
([#4352](https://github.com/open-telemetry/opentelemetry-specification/pull/4352))
- Logs API should have ergonomics for reusing standard attributes.
([#4373](https://github.com/open-telemetry/opentelemetry-specification/pull/4373))

### Events

Expand Down
9 changes: 8 additions & 1 deletion specification/logs/api.md
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,16 @@ The API MUST accept the following parameters:
- [Severity Number](./data-model.md#field-severitynumber) (optional)
- [Severity Text](./data-model.md#field-severitytext) (optional)
- [Body](./data-model.md#field-body) (optional)
- [Attributes](./data-model.md#field-attributes) (optional)
- [Attributes](./data-model.md#field-attributes) (optional) [1]
- **Status**: [Development](../document-status.md) - [Event Name](./data-model.md#field-eventname) (optional)

[1]: **Status**: [Development](../document-status.md) -
pellared marked this conversation as resolved.
Show resolved Hide resolved
The API SHOULD provide ergonomics so that the caller can use
pellared marked this conversation as resolved.
Show resolved Hide resolved
pellared marked this conversation as resolved.
Show resolved Hide resolved
[Standard Attributes](../common/README.md#standard-attribute)
along with log attributes of [type `map<string, any>`](./data-model.md#type-mapstring-any).
This allows the reuse of attributes across signals.
pellared marked this conversation as resolved.
Show resolved Hide resolved
This can be converting functions, method overloads, etc.

### Enabled

**Status**: [Development](../document-status.md)
Expand Down
Loading