-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ActiveStorage instrumentation #1313
base: main
Are you sure you want to change the base?
feat: Add ActiveStorage instrumentation #1313
Conversation
7a91acc
to
641f823
Compare
721c056
to
5959af8
Compare
5959af8
to
cf7ee82
Compare
instrumentation/active_storage/lib/opentelemetry/instrumentation/active_storage/version.rb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @ymtdzzz! I'm looking forward to OTel to offering ActiveStorage support.
...mentation/active_storage/lib/opentelemetry/instrumentation/active_storage/instrumentation.rb
Show resolved
Hide resolved
...mentation/active_storage/lib/opentelemetry/instrumentation/active_storage/instrumentation.rb
Outdated
Show resolved
Hide resolved
...mentation/active_storage/lib/opentelemetry/instrumentation/active_storage/instrumentation.rb
Show resolved
Hide resolved
instrumentation/active_storage/opentelemetry-instrumentation-active_storage.gemspec
Outdated
Show resolved
Hide resolved
…th other packages
…ve active_storage from all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the updates! 😄
The last thing I can think of would be to update the CODEOWNERS file to add your name to the list of reviewers. The OpenTelemetry Ruby team needs help from end users and other experts in the community to maintain our instrumentation. Since you built this Active Storage instrumentation, we'd love for you to help us maintain the library going forward. By becoming a CODEOWNER, you would be added as a reviewer to any PR opened to update the instrumentaiton/active_storage
code. We may also tag you directly in issues raised regarding the Active Storage instrumentation.
Would you be comfortable with this?
I'd also like @xuan-cao-swi to take another look when he has a chance.
Thank you for the suggestion! Of course I'm happy to help with reviews and issues regarding the instrumentation! I'm looking forward to collaborating with the team! |
9221f0d
to
b5a65bd
Compare
Description
Adding support for instrumenting ActiveStorage using ActiveSupport::Notification.
related: #1307
Test
Example script
With other instrumentations in your Rails app
Without ActiveStorage instrumentation
With ActiveStorage instrumentation