Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] move controllers under internal #3633

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[chore] move controllers under internal #3633

wants to merge 1 commit into from

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 20, 2025

Description:
Move controllers under internal so their API is not exported.

@atoulme atoulme requested a review from a team as a code owner January 20, 2025 00:52
@swiatekm
Copy link
Contributor

This placement of controllers is a kubebuilder standard. I'm not sure how much that matters to us at this point, but it would certainly make the migration to kubebuilder v4 more difficult. WDYT @open-telemetry/operator-approvers ?

@jaronoff97
Copy link
Contributor

Yes, i think we should do the kubebuilder v4 migration first as that unblocks a few other issues IIRC.

@atoulme
Copy link
Contributor Author

atoulme commented Jan 21, 2025

I don't see an issue for moving to kubebuilder 4, is it ok to open one? Is anyone working on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atoulme @swiatekm @jaronoff97