Ensuring the collector behavior remains consistent when mTLS feature gate is enabled but TA is not deployed

[ItielOlenick]

Description:
Ensuring the collector behavior remains consistent when mTLS feature gate is enabled but TA is not deployed

Link to tracking Issue(s):

• Resolves: Enabling operator.targetallocator.mtls results in non-existent certificate mounts for non-Prometheus collectors #3456

Testing:
Local

Documentation:
No documentation changes needed

[jaronoff97]

Some test failures, but i think this is a fine fix for now.

[ItielOlenick]

Pretty sure the CI test failure has nothing to do with the code changes.

[swiatekm]

Pretty sure the CI test failure has nothing to do with the code changes.

It looks like the only unit tests failing are ones related to the mTLS feature, so that would be quite the coincidence.

[ItielOlenick]

Pretty sure the CI test failure has nothing to do with the code changes.

It looks like the only unit tests failing are ones related to the mTLS feature, so that would be quite the coincidence.

Sorry, my bad.
I have fixed the unit tests.

[swiatekm]

@ItielOlenick could you add a changelog entry? I wouldn't mind seeing a simple e2e test with the flag enabled but targetAllocator disabled.

[ItielOlenick]

@ItielOlenick could you add a changelog entry? I wouldn't mind seeing a simple e2e test with the flag enabled but targetAllocator disabled.

You got it.
Will add those.

[ItielOlenick]

@swiatekm anything missing?

[swiatekm]

@swiatekm anything missing?

You said you'd add an e2e test, but I don't see it in this PR.

[ItielOlenick]

@swiatekm anything missing?

You said you'd add an e2e test, but I don't see it in this PR.

Sorry, i misread that for tests in general.
Added both.
For some reason the changelog (which I added) is not picked up in the recent CI job.

[swiatekm]

For some reason the changelog (which I added) is not picked up in the recent CI job.

Can you rebase your changes on main? Github doesn't show this in the diff, but your branch has changelog fragments from before the most recent release.

[ItielOlenick]

For some reason the changelog (which I added) is not picked up in the recent CI job.

Can you rebase your changes on main? Github doesn't show this in the diff, but your branch has changelog fragments from before the most recent release.

Done

[swiatekm]

The changelog issue is fixed in #3595, so you won't need to delete the entry file after that's merged.