Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Jacob Aronoff <[email protected]>
  • Loading branch information
swiatekm and jaronoff97 authored Dec 2, 2024
1 parent c1c325d commit e75275a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions controllers/targetallocator_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ func (r *TargetAllocatorReconciler) getParams(ctx context.Context, instance v1al

// getCollector finds the OpenTelemetryCollector for the given TargetAllocator. We have the following possibilities:
// - Collector is the owner of the TargetAllocator
// - Collector is annotated with the TargetAllocator's name
// - Collector is labeled with the TargetAllocator's name
// - No collector
func (r *TargetAllocatorReconciler) getCollector(ctx context.Context, instance v1alpha1.TargetAllocator) (*v1beta1.OpenTelemetryCollector, error) {
var collector v1beta1.OpenTelemetryCollector
Expand All @@ -105,7 +105,7 @@ func (r *TargetAllocatorReconciler) getCollector(ctx context.Context, instance v
return &collector, nil
}

// check if there are Collectors annotated with this Target Allocator's name
// check if there are Collectors labeled with this Target Allocator's name
var collectors v1beta1.OpenTelemetryCollectorList
listOpts := []client.ListOption{
client.InNamespace(instance.GetNamespace()),
Expand Down

0 comments on commit e75275a

Please sign in to comment.