-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log: Add ValueFromAttribute and KeyValueFromAttribute #6180
Merged
+238
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6180 +/- ##
=====================================
Coverage 82.2% 82.2%
=====================================
Files 273 273
Lines 23674 23720 +46
=====================================
+ Hits 19478 19521 +43
- Misses 3849 3852 +3
Partials 347 347 |
pellared
requested review from
MrAlias,
XSAM,
dashpole and
dmathieu
as code owners
January 20, 2025 11:42
dmathieu
approved these changes
Jan 20, 2025
dashpole
approved these changes
Jan 21, 2025
MrAlias
reviewed
Jan 21, 2025
pellared
changed the title
log: Add ConvertAttributeValue and ConvertAttributeKeyValue
log: Add ValueFromAttribute and KeyValueFromAttribute
Jan 21, 2025
MrAlias
reviewed
Jan 21, 2025
MrAlias
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6158
Related spec PR: open-telemetry/opentelemetry-specification#4373
Benchmark results: