Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to go-redis/v8 #1522

Closed

Conversation

minimAluminiumalism
Copy link
Contributor

Ref #1053

This project currently does not support Redis. Instrumentation for the library github.com/go-redis/redis/v8 is quite complex, primarily because some of the available instrumentation functions include parameters of type interface{} (this issue is also mentioned in #1209) like this:

func (c *baseClient) process(ctx context.Context, cmd Cmder)

This PR implements support for go-redis/v8. In fact, since the key instrument functions in go-redis/v9 remain unchanged, support for v9 might also be possible in the future. The approach involves detecting the interface{} type, first determining the specific type, and then retrieving the corresponding value based on that type.

However, at the moment, only the standard mode of Redis is supported, and pipeline mode is not yet supported. Plans are in place to add support for pipeline mode in the future.

CR @MrAlias

@minimAluminiumalism minimAluminiumalism requested a review from a team as a code owner December 25, 2024 18:05
Copy link

linux-foundation-easycla bot commented Dec 25, 2024

CLA Missing ID CLA Not Signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant