-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to go-redis/v8 #1522
Closed
minimAluminiumalism
wants to merge
20
commits into
open-telemetry:main
from
minimAluminiumalism:inst_redis
Closed
Add support to go-redis/v8 #1522
minimAluminiumalism
wants to merge
20
commits into
open-telemetry:main
from
minimAluminiumalism:inst_redis
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fsets [auto] Update generated offsets
…fsets [auto] Update generated offsets
|
minimAluminiumalism
force-pushed
the
inst_redis
branch
from
December 25, 2024 18:15
92cd325
to
3b46717
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1053
This project currently does not support Redis. Instrumentation for the library
github.com/go-redis/redis/v8
is quite complex, primarily because some of the available instrumentation functions include parameters of typeinterface{}
(this issue is also mentioned in #1209) like this:This PR implements support for
go-redis/v8
. In fact, since the key instrument functions in go-redis/v9 remain unchanged, support for v9 might also be possible in the future. The approach involves detecting the interface{} type, first determining the specific type, and then retrieving the corresponding value based on that type.However, at the moment, only the standard mode of Redis is supported, and pipeline mode is not yet supported. Plans are in place to add support for pipeline mode in the future.
CR @MrAlias