[exporter][batcher] Add the API ByteSize() to exporter.Request #12153
+75
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-sili
requested review from
bogdandrutu,
dmitryax and
a team
as code owners
sfc-gh-sili
force-pushed
the
sili-bytes-based-batching-pre
branch
from
cf461ca to
5d09bf6
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (66.66%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #12153 +/- ##
==========================================
- Coverage 91.75% 91.21% -0.54%
==========================================
Files 464 466 +2
Lines 24763 25668 +905
==========================================
+ Hits 22722 23414 +692
- Misses 1656 1841 +185
- Partials 385 413 +28 ☔ View full report in Codecov by Sentry. |
sfc-gh-sili
force-pushed
the
sili-bytes-based-batching-pre
branch
from
5d09bf6 to
bba043f
Compare
|
@dmathieu Hi Damien, I added a couple of tests to check the new API. Would you mind taking another look? |
dmathieu
reviewed
Jan 29, 2025
exporter/exporterhelper/logs_test.go
Outdated
| @@ -43,6 +43,8 @@ var ( | |||
|
|
|||
| func TestLogsRequest(t *testing.T) { | |||
| lr := newLogsRequest(testdata.GenerateLogs(1), nil) | |||
| assert.Equal(t, 1, lr.ItemsCount()) | |||
| assert.Equal(t, logsMarshaler.LogsSize(testdata.GenerateLogs(1)), lr.ByteSize()) | |||
There was a problem hiding this comment.
IMHO, this (and the other tests) should test against a static value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the API to
ByteSize()toexporter.RequestLink to tracking issue
#3262
Testing
Documentation