Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature command #12014

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

danish9039
Copy link

Description

  • add features command

Link to tracking issue

Testing

  • test with make
  • test with make test

Documentation

Signed-off-by: danish9039 <[email protected]>
Signed-off-by: danish9039 <[email protected]>
@danish9039 danish9039 requested review from djaglowski and a team as code owners January 4, 2025 22:02
Copy link

linux-foundation-easycla bot commented Jan 4, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

service/display_feature.go Outdated Show resolved Hide resolved
service/display_feature.go Outdated Show resolved Hide resolved
service/display_feature.go Outdated Show resolved Hide resolved
otelcol/command.go Outdated Show resolved Hide resolved
otelcol/command.go Outdated Show resolved Hide resolved

func newFeaturesCommand() *cobra.Command {
return &cobra.Command{
Use: "features [feature-id]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@open-telemetry/collector-approvers do you prefer features? gates? featuregates?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

features sounds better to me

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs a changelog

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 17.64706% with 28 lines in your changes missing coverage. Please review.

Project coverage is 91.60%. Comparing base (de320aa) to head (b12de3e).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
otelcol/command.go 17.64% 27 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12014      +/-   ##
==========================================
- Coverage   91.70%   91.60%   -0.11%     
==========================================
  Files         455      455              
  Lines       24053    24087      +34     
==========================================
+ Hits        22058    22064       +6     
- Misses       1625     1652      +27     
- Partials      370      371       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants