[chore] Ability to provide custom ld and gc flags #11996
Merged
+63
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dainerx
force-pushed
the
builder/ld-gc-flags
branch
from
9889e99 to
a6d8bb0
Compare
Dainerx
changed the title
Dainerx
force-pushed
the
builder/ld-gc-flags
branch
from
c3b79eb to
ee35153
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11996 +/- ##
=======================================
Coverage 91.71% 91.72%
=======================================
Files 463 463
Lines 24803 24821 +18
=======================================
+ Hits 22749 22767 +18
Misses 1672 1672
Partials 382 382 ☔ View full report in Codecov by Sentry. |
mx-psi
approved these changes
Jan 10, 2025
| @@ -71,7 +74,7 @@ type Distribution struct { | |||
| OutputPath string `mapstructure:"output_path"` | |||
| Version string `mapstructure:"version"` | |||
| BuildTags string `mapstructure:"build_tags"` | |||
| DebugCompilation bool `mapstructure:"debug_compilation"` | |||
| DebugCompilation bool `mapstructure:"debug_compilation"` // TODO depercate? | |||
There was a problem hiding this comment.
Instead of TODOs in code, please file an issue :)
Suggested change
| DebugCompilation bool `mapstructure:"debug_compilation"` // TODO depercate? | |
| DebugCompilation bool `mapstructure:"debug_compilation"` |
…rovide custom ld and gc flags
Dainerx
force-pushed
the
builder/ld-gc-flags
branch
from
ffc36a7 to
e2ee644
Compare
auto-merge was automatically disabled
January 21, 2025 10:47
Pull Request is not mergeable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The primary purpose of this PR is to provide greater flexibility in how OTEL binaries are built, enabling the inclusion of debugging symbols when needed, without always stripping them by default.
Currently, debugging symbols are only retained when debug_compilation=true. However, this approach also disables all compiler inlining and optimizations (gcflags=all=-N -l) to ensure an exact match between written and executed code, resulting in a significant increase in CPU consumption. There are scenarios where we want binaries with debugging symbols and DWARF information while still allowing the compiler to optimize and inline. This PR addresses that need by introducing configurable GCFlags.
ocb --ldflags="" --gcflags="" --config=builder-config.yamlLink to tracking issue
Fixes #58
Testing
Manual
Override LDflags:
Override both
Documentation
README file updated.
--
Backward compatibility concerns:
-s -w.Questions: