[processor/batch] Allow multiple batches for each batch size trigger #11962
+37
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11962 +/- ##
==========================================
- Coverage 91.67% 91.67% -0.01%
==========================================
Files 455 455
Lines 24039 24036 -3
==========================================
- Hits 22038 22035 -3
Misses 1629 1629
Partials 372 372 ☔ View full report in Codecov by Sentry. |
lopes-felipe
changed the title
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Hey @codeboten. Could you please take a look whenever you can? Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a config validation which enforces that
send_batch_max_sizemust be greater thansend_batch_size. This makes it impossible to have a setup of a batch that is triggered when a number of items are processed (SendBatchSize), but we want to break that set into multiple smaller batches (SendBatchMaxSize<SendBatchSize).This logic was introduced here, due to this issue, but the underlying bug was fixed here, so this validation shouldn't exist anymore.