[elasticsearchexporter] Consistently store the structured body of logs and events in otel mode
#37387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixbarny
changed the title
otel modeotel mode
Co-authored-by: Carson Ip <[email protected]>
carsonip
approved these changes
Jan 22, 2025
|
Hey @andrzej-stencel, I think this is ready to be merged. Could you have a look? 🙂 |
| # Use this changelog template to create an entry for release notes. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: breaking |
There was a problem hiding this comment.
The otel mapping mode used to be unstable, but that warning has been removed in the latest version, v0.118.0. This change is now a breaking change in a Beta stability component. What are the consequences to users upgrading the collector? Will this cause the data to be rejected by Elasticsearch? Can this be somehow alleviated by the user?
There was a problem hiding this comment.
Data will still be ingested, no rejections. It will just be mapped differently. The field body.structured already exists, it will just be used for all kinds of bodies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OTel community has reached a consensus that all structured data for events defined by semantic conventions should be stored in attributes (open-telemetry/semantic-conventions#1651 (comment)). The body for events may contain opaque/external data, which sounds like a job for the flattened field type.
Therefore, it no longer makes sense to map the body for logs and events differently.
The corresponding Elasticsearch mapping change has been merged already: elastic/elasticsearch#120547