Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/envoyals] init new receiver #37193

Merged
merged 16 commits into from
Jan 23, 2025
Merged

[receiver/envoyals] init new receiver #37193

merged 16 commits into from
Jan 23, 2025

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Jan 14, 2025

Description

Add a new receiver for the Envoy ALS (Access Log Service)

Link to tracking issue

Fixes #36464

cc @evan-bradley

@zirain zirain requested a review from a team as a code owner January 14, 2025 06:37
@zirain zirain requested a review from ChrsMark January 14, 2025 06:37
@github-actions github-actions bot added the cmd/otelcontribcol otelcontribcol command label Jan 14, 2025
@zirain zirain force-pushed the anvoy-als-receiver branch from bea3704 to a5d1e52 Compare January 14, 2025 06:38
@zirain
Copy link
Contributor Author

zirain commented Jan 14, 2025

wait #37194

@zirain zirain force-pushed the anvoy-als-receiver branch from afaca7d to 02fd711 Compare January 15, 2025 01:13
zirain added 3 commits January 15, 2025 10:13
@zirain
lint
383d1f5 
Signed-off-by: zirain <[email protected]>
@zirain
gomod tidy
ccde1d8 
Signed-off-by: zirain <[email protected]>
@zirain
gendistributions
b49b3c6 
Signed-off-by: zirain <[email protected]>
@zirain
update README
fde4bb1 
Signed-off-by: zirain <[email protected]>
zirain added 2 commits January 17, 2025 08:57
@zirain
address comments
38afc98 
Signed-off-by: zirain <[email protected]>
@zirain
gendistributions
fc83b16 
Signed-off-by: zirain <[email protected]>
@zirain zirain requested review from atoulme and joaopgrassi January 18, 2025 04:37
@atoulme
Copy link
Contributor

atoulme commented Jan 18, 2025

Please fix the conflict.

@zirain
Copy link
Contributor Author

zirain commented Jan 18, 2025

/retest

@zirain
Copy link
Contributor Author

zirain commented Jan 22, 2025

kindly ping @atoulme @evan-bradley @joaopgrassi

evan-bradley
evan-bradley approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed review. None of my comments are blocking.

.chloggen/anvoy-als-receiver.yaml Outdated Show resolved Hide resolved
receiver/envoyalsreceiver/README.md Outdated Show resolved Hide resolved
receiver/envoyalsreceiver/README.md Outdated Show resolved Hide resolved
receiver/envoyalsreceiver/factory.go Outdated Show resolved Hide resolved
receiver/envoyalsreceiver/internal/als/server.go Outdated Show resolved Hide resolved
receiver/envoyalsreceiver/internal/als/server.go Outdated Show resolved Hide resolved
receiver/envoyalsreceiver/internal/als/server.go Show resolved Hide resolved
@evan-bradley evan-bradley merged commit 11e18af into open-telemetry:main Jan 23, 2025
164 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 23, 2025
@zirain zirain deleted the anvoy-als-receiver branch January 23, 2025 15:02
@zirain
Copy link
Contributor Author

zirain commented Jan 23, 2025

@evan-bradley Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-bradley evan-bradley evan-bradley approved these changes

@ChrsMark ChrsMark Awaiting requested review from ChrsMark ChrsMark is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

@atoulme atoulme Awaiting requested review from atoulme

@joaopgrassi joaopgrassi Awaiting requested review from joaopgrassi

Assignees

@bogdandrutu bogdandrutu

Labels
cmd/otelcontribcol otelcontribcol command reports/distributions/contrib.yaml reports/distributions/k8s.yaml
Projects
None yet
Milestone
next release
Development

Successfully merging this pull request may close these issues.

New component: Envoy access log receiver
5 participants
@zirain @atoulme @joaopgrassi @evan-bradley @bogdandrutu