Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[elasticsearchexporter] Handle EventName #37012

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[elasticsearchexporter] Handle EventName #37012

wants to merge 4 commits into from
+70 −6

Conversation

felixbarny
Copy link
Contributor

closes #37011

@felixbarny felixbarny requested a review from a team as a code owner January 2, 2025 18:04
@felixbarny felixbarny changed the title Handle EventName [elasticsearchexporter] Handle EventName Jan 2, 2025
felixbarny added a commit to felixbarny/elasticsearch that referenced this pull request Jan 3, 2025
@felixbarny
Add mapping for event_name
77dfd47 
Relates to open-telemetry/opentelemetry-collector-contrib#37012
@felixbarny felixbarny mentioned this pull request Jan 3, 2025
Merged
@felixbarny
Copy link
Contributor Author

Related ES mapping changes: elastic/elasticsearch#119495

lahsivjar
lahsivjar approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@lahsivjar lahsivjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

carsonip
carsonip reviewed Jan 3, 2025
View reviewed changes
Copy link
Contributor

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, thanks!

exporter/elasticsearchexporter/model.go Outdated Show resolved Hide resolved
.chloggen/elasticsearchexporter_event-name.yaml Outdated Show resolved Hide resolved
carsonip
carsonip approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredTan95 JaredTan95 JaredTan95 approved these changes

@carsonip carsonip carsonip approved these changes

@lahsivjar lahsivjar lahsivjar approved these changes

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

At least 1 approving review is required to merge this pull request.

Assignees

@djaglowski djaglowski

Labels
exporter/elasticsearch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[elasticsearchexporter] Handle new top-level event name field
5 participants
@felixbarny @lahsivjar @carsonip @JaredTan95 @djaglowski