[receiver/netflow] Netflow receiver implementation - PR 2 #36865

dlopes7 · 2024-12-16T23:58:34Z

#34164 added the skeleton for the netflow receiver, this adds the implementation along with tests

Implement the receiver construction, along with the UDP listener that receives the packets
Implement the producer, the function that is responsible for parsing the data and sending it to the consumers
Add tests

Link to tracking Issue: #32732

This adds the implementation for netflow receiver Introduces: * The OtelLogsProducerWrapper * A parser function to convert proto to otel semantics * The listener implementation as well as the error handling function

…ener

…plementation

.chloggen/netflow-receiver-implementation.yaml

receiver/netflowreceiver/factory.go

receiver/netflowreceiver/config_test.go

receiver/netflowreceiver/parser.go

receiver/netflowreceiver/receiver.go

.chloggen/netflow-receiver-implementation.yaml

receiver/netflowreceiver/receiver.go

Co-authored-by: Evan Bradley <[email protected]>

Use the semconv constants for the attribute keys where applicable

Co-authored-by: Evan Bradley <[email protected]>

receiver/netflowreceiver/config_test.go

receiver/netflowreceiver/producer.go

Co-authored-by: Evan Bradley <[email protected]>

…opentelemetry-collector-contrib into netflow-receiver-implementation

receiver/netflowreceiver/parser_test.go

…plementation

dlopes7 added 10 commits December 15, 2024 13:40

open-telemetry#32732 - Initial implementation

f7ff90b

This adds the implementation for netflow receiver Introduces: * The OtelLogsProducerWrapper * A parser function to convert proto to otel semantics * The listener implementation as well as the error handling function

open-telemetry#32732 - Make internal methods private

9871936

open-telemetry#32732 - netflow - make checks

09a91d1

open-telemetry#32732 - netflow - simplify implementation, remove list…

26d5aec

…ener

netflow - add parser tests

64acc94

netflow - add more tests

658c414

netflow - add test to check for udp receiver creation

0a50dbb

netflow - gofmt

dd6a006

Merge remote-tracking branch 'upstream/main' into netflow-receiver-im…

363f93b

…plementation

netflow - make checks

3854269

dlopes7 requested review from evan-bradley and a team as code owners December 16, 2024 23:58

github-actions bot assigned bogdandrutu Dec 16, 2024

github-actions bot added the receiver/netflow label Dec 16, 2024

dlopes7 added 8 commits December 16, 2024 18:03

netflowreceiver - add changelog for implementation

0fe206e

netflow - fix license header

d7c0782

netflowreceiver - lint

b343ab4

Merge branch 'main' into netflow-receiver-implementation

f504466

Merge branch 'main' into netflow-receiver-implementation

d31a81e

Merge branch 'main' into netflow-receiver-implementation

8d07a6a

Merge branch 'main' into netflow-receiver-implementation

f7b1512

Merge remote-tracking branch 'upstream/main' into netflow-receiver-im…

33d0cee

…plementation

evan-bradley reviewed Jan 2, 2025

View reviewed changes

dlopes7 and others added 7 commits January 2, 2025 12:26

netflow - update .chloggen/netflow-receiver-implementation.yaml

5e178ac

Co-authored-by: Evan Bradley <[email protected]>

netflow - remove scaffold issue

ebfa73d

Co-authored-by: Evan Bradley <[email protected]>

netflow - add comment about default queue size value

86701b9

Co-authored-by: Evan Bradley <[email protected]>

netflow - fix duplicate test case

52bca59

Co-authored-by: Evan Bradley <[email protected]>

netflow - fix typo

edbbbc0

Co-authored-by: Evan Bradley <[email protected]>

netflow - better error handling messages

d68e826

netflow - use a simple log record instead of struct

053543c

Use the semconv constants for the attribute keys where applicable

dlopes7 and others added 5 commits January 13, 2025 11:06

netflow - remove unecessary log line

583915e

Co-authored-by: Evan Bradley <[email protected]>

netflow - move flow keys to 'flow.' namespace

64aed8c

netflow - update readme keys

ab9b6c1

Merge branch 'main' into netflow-receiver-implementation

dd8f7d9

netflow - adjust validSchemes slice size

fed610b

strawgate reviewed Jan 13, 2025

View reviewed changes

receiver/netflowreceiver/config_test.go Show resolved Hide resolved

dlopes7 added 4 commits January 13, 2025 11:39

netflow - clarify minimum queue size

f77489b

netflow - simplify panic handling

44e134e

netflow - formatting and remove a comment

f6526d6

Merge branch 'main' into netflow-receiver-implementation

5c07873

evan-bradley reviewed Jan 13, 2025

View reviewed changes

receiver/netflowreceiver/producer.go Outdated Show resolved Hide resolved

receiver/netflowreceiver/producer.go Outdated Show resolved Hide resolved

dlopes7 and others added 7 commits January 13, 2025 17:02

Update receiver/netflowreceiver/producer.go

59633be

Co-authored-by: Evan Bradley <[email protected]>

Update receiver/netflowreceiver/producer.go

75cba97

Co-authored-by: Evan Bradley <[email protected]>

netflow - fix panic handling and test for it

af1e72b

Merge branch 'main' into netflow-receiver-implementation

da9b68e

Merge branch 'netflow-receiver-implementation' of github.com:dlopes7/…

e72e3f3

…opentelemetry-collector-contrib into netflow-receiver-implementation

Merge branch 'main' into netflow-receiver-implementation

22c12b2

Merge branch 'main' into netflow-receiver-implementation

075d87b

evan-bradley approved these changes Jan 15, 2025

View reviewed changes

receiver/netflowreceiver/parser_test.go Show resolved Hide resolved

dlopes7 and others added 8 commits January 16, 2025 07:34

netflow - add tests for parsed timestamps

9049e77

Merge remote-tracking branch 'upstream/main' into netflow-receiver-im…

735ab5a

…plementation

netflow - go mod tidy

9eb1955

netflow - update semconv

838e479

Merge branch 'main' into netflow-receiver-implementation

bbd7c38

Merge remote-tracking branch 'upstream/main' into netflow-receiver-im…

41c116f

…plementation

netflow - update semconv

a67b9ad

go mod tidy

40cc5ec

evan-bradley merged commit 96e7cd8 into open-telemetry:main Jan 22, 2025
164 checks passed

github-actions bot added this to the next release milestone Jan 22, 2025

LucasHocker mentioned this pull request Jan 23, 2025

New component: netflow receiver #32732

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[receiver/netflow] Netflow receiver implementation - PR 2 #36865

[receiver/netflow] Netflow receiver implementation - PR 2 #36865

dlopes7 commented Dec 16, 2024 •

edited

Loading

[receiver/netflow] Netflow receiver implementation - PR 2 #36865

[receiver/netflow] Netflow receiver implementation - PR 2 #36865

Conversation

dlopes7 commented Dec 16, 2024 • edited Loading

dlopes7 commented Dec 16, 2024 •

edited

Loading