-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add @madevanni as a contributor #633
base: main
Are you sure you want to change the base?
Conversation
Congratulations on completing the How to Contribute to Open Source chapter of the Intro to Open Source Course with your contribution to this repository, @madevanni! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in the next chapter and share it with us! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! β€οΈ! ππ
Say hello by joining the conversation in our Discord
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @madevanni,
Thank you for your contribution! β¨
There are a few things here:
- You have a failed check that you need to address before we can review your PR. Please fix it until all checks pass.
- Please add description to your PR template.
- We have merged a PR before yours. Please resolve the merge conflicts so we can review and merge your PR.
Let me know once you've fixed them, or if you have questions or need help.
Thank you. π
Description
What type of PR is this? (check all applicable)
Related Issues
Contributors Checklist
I've read through the Getting Started section
Have you run
npm run contributors:generate
to generate your profile and the badge on the README?Added to documentation?
Screenshot (Required for PR Review)
[optional] What GIF best describes this PR or how it makes you feel?