Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File with and without errors - Change in icon #510

Open
romicolman opened this issue Aug 16, 2024 · 1 comment
Open

File with and without errors - Change in icon #510

romicolman opened this issue Aug 16, 2024 · 1 comment
Assignees

Comments

@romicolman
Copy link
Collaborator

Description

In the current version of the ODE, whenever a user ingest a file with errors, the ODE shows the ERRORS button and the icon next to the name of the file in red.

In a previous ticket (#505) we removed the ERRORS/VALID button.

For the new main screen, instead of a "file icon" (red or green):

Captura de pantalla 2024-08-16 a la(s) 10 29 27 a  m

We will use a dot (red or green):

Example 1.csv: file with no errors

File 2. csv: file with errors

Captura de pantalla 2024-08-16 a la(s) 10 34 17 a  m

Figma file here.

To sum up: the logic is the same. We are just changing the icon.

@guergana
Copy link
Collaborator

This was done as part of #506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants