handle unsupported null constants like float32 constants #3564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheNumbat
approved these changes
Feb 11, 2025
All tests under |
dkalinichenko-js
force-pushed
the
dkalinichenko/bytecode-stage1-null
branch
from
2302b95 to
bdc1133
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like float32 constants, null constants are not supported by the upstream bytecode marshalling functions. Since we run
flambda_backend/testsusing the stage 1/bootstrap compiler using the upstream runtime, movingor_nullto stable runs into this problem again.Eventually, we should just build those tests using the final compiler. But for now, it's easier to do the same trick for
or_null.Tested by #3565.