local implies yielding
#3532
Open
local implies yielding
#3532
+397
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkalinichenko-js
commented
Feb 3, 2025
| @@ -176,7 +176,7 @@ let disallowed_by_regionality (local_ unique_ r) x = | |||
| Line 3, characters 16-17: | |||
| 3 | let ref = ref r in | |||
| ^ | |||
| Error: This value escapes its region. | |||
| Error: This value is "yielding" but expected to be "unyielding". | |||
There was a problem hiding this comment.
This error message got worse. I'm not sure what to do about it, since the axis on which we fail submoding is produced by the mode solver.
dkalinichenko-js
force-pushed
the
dkalinichenko/local-implies-yielding
branch
from
0a38111 to
00ad634
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
yieldingmode the default iflocalis set. The change is only limited to syntax parsing and does not change the inference code. To preserve consistency, theglobalmodality/modifier now also impliesunyieldingby default, and[@local_opt]also varies along theyieldingaxis.Subsequent PRs will add
yieldingannotations to the Capsule API and to the Effects API.The printer now displays
stack_allocation return values with@ unyielding, as intended.This change sometimes causes principal and non-principal type inference to diverge when the old syntax for
local_annotations is used. I'm surprised this compiler option affects syntax parsing, but the issue seems benign.