don't mark extensible variants as best

it's weird, and we don't need it, so let's just remove it
ocaml-flambda · Jan 31, 2025 · e105547 · e105547
1 parent 4f07283
commit e105547
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/typing/typedecl.ml b/typing/typedecl.ml
@@ -980,7 +980,7 @@ let transl_declaration env sdecl (id, uid) =
           Type_record_unboxed_product(lbls', Record_unboxed_product), jkind
       | Ptype_open ->
         Ttype_open, Type_open,
-        (Jkind.Builtin.value ~why:Extensible_variant |> Jkind.mark_best)
+        Jkind.Builtin.value ~why:Extensible_variant
       in
     let jkind =
     (* - If there's an annotation, we use that. It's checked against
@@ -1839,10 +1839,7 @@ let update_decl_jkind env dpath decl =
       assert (not (Jkind.is_best decl.type_jkind));
       decl, decl.type_jkind
     | Type_open ->
-      let type_jkind =
-        Jkind.Builtin.value ~why:Extensible_variant
-        |> Jkind.mark_best
-      in
+      let type_jkind = Jkind.Builtin.value ~why:Extensible_variant in
       { decl with type_jkind }, type_jkind
     | Type_record (lbls, rep) ->
       let lbls, rep, type_jkind = update_record_kind decl.type_loc lbls rep in