Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NuxtPicture): make img-attrs and attrs responsive #1696

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

codeflorist
Copy link
Contributor

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The imgAttrs property in NuxtPicture was not responsive as of yet. This commit changes that.

@codeflorist codeflorist force-pushed the feat-responsive-img-attrs branch from 1caa28e to 85f5826 Compare February 8, 2025 15:35
@codeflorist codeflorist force-pushed the feat-responsive-img-attrs branch from 85f5826 to 5443f12 Compare February 8, 2025 15:58
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.59%. Comparing base (e516ea3) to head (5443f12).

Files with missing lines Patch % Lines
src/runtime/components/NuxtPicture.vue 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1696      +/-   ##
==========================================
+ Coverage   63.56%   63.59%   +0.03%     
==========================================
  Files          79       79              
  Lines        3631     3634       +3     
  Branches      424      425       +1     
==========================================
+ Hits         2308     2311       +3     
  Misses       1295     1295              
  Partials       28       28              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@danielroe danielroe changed the title fix(NuxtPicture): make img-attrs prop responsive fix(NuxtPicture): make img-attrs and attrs responsive Feb 8, 2025
@danielroe danielroe merged commit 279a981 into nuxt:main Feb 8, 2025
3 checks passed
@github-actions github-actions bot mentioned this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants