Add support for the v1 alerts api. #244
Conversation
- Add code to call api. - Add testcases. - Add example.
| @@ -0,0 +1,46 @@ | |||
| package alerting | |||
There was a problem hiding this comment.
oh nice, more models! its not like that we did not have enough already :D
There was a problem hiding this comment.
not a jab at the PR but rather than the fact that we have a 1000 models!
| var client *api.Client | ||
|
|
||
| // Helper that initializes rest api client from environment variable. | ||
| func init() { |
There was a problem hiding this comment.
Is this called in the example somewhere?
There was a problem hiding this comment.
If I'm 100% honest this is here because I started by copying one of the other examples and wanted it to follow our existing pattern.
It will always be called as go ensures the init() function for a file is always run:
https://go.dev/doc/effective_go#init
(The internet seems rather divided on whether it's a bad thing to use which in general but it's probably ok for samples like this.)
- Use alerting/v1 in REST calls. - Update changelog and client version. - Minor fix to example to create secondary zone correctly.
hhellyer
changed the title
|
|
||
| defaultBase = "http://localhost:80" | ||
| defaultBase = "https://api.nsone.net" |
There was a problem hiding this comment.
why did you change this?
This PR adds support for the alerts api.