fix(js): ensure js libraries' build produce esm output in ts solution setup #29546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 4d49725.
☁️ Nx Cloud last updated this comment at |
leosvelperez
changed the title
leosvelperez
force-pushed
the
js/ts-setup-output-esm
branch
from
bc23be2 to
3f97d26
Compare
leosvelperez
force-pushed
the
js/ts-setup-output-esm
branch
from
3f97d26 to
4d49725
Compare
jaysoo
reviewed
Jan 8, 2025
| const allDiagnostics = ts | ||
| .getPreEmitDiagnostics(program as Program) | ||
| .concat(result.diagnostics); | ||
| const allDiagnostics = options.ignoreDiagnostics |
There was a problem hiding this comment.
Makes sense for correctness. We should look at it again in the future to see if want to allow builds without typechecks, maybe a separate typedefs task for swc and esbuild so users that do not need d.ts files don't need to pay the penalty.
jaysoo
approved these changes
Jan 8, 2025
|
Failed to publish a PR release of this pull request, triggered by @leosvelperez. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
esbuild,swc, andtscto produce ESM output when using the TS solution setup.esbuildandswcexecutors so they generate declaration files even when skipping type-checking.cjsandctsto theignoredFilespattern for the rollup config file in the eslint config.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #