Merge pull request #106 from unexge/external-id-option

Add missing `external_id` option to NotificationResolver. Closes #104
norkunas · Dec 17, 2018 · d876ad4 · d876ad4
1 parent 1087b0b
commit d876ad4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/Resolver/NotificationResolver.php b/src/Resolver/NotificationResolver.php
@@ -206,6 +206,8 @@ public function resolve(array $data)
             ->setAllowedTypes('email_from_name', 'string')
             ->setDefined('email_from_address')
             ->setAllowedTypes('email_from_address', 'string')
+            ->setDefined('external_id')
+            ->setAllowedTypes('external_id', 'string')
             ->resolve($data);
     }
 

diff --git a/tests/OneSignal/Tests/Resolver/NotificationResolverTest.php b/tests/OneSignal/Tests/Resolver/NotificationResolverTest.php
@@ -108,6 +108,7 @@ public function testResolveWithValidValues()
             'email_body' => 'value',
             'email_from_name' => 'value',
             'email_from_address' => 'value',
+            'external_id' => 'value',
         ];
 
         $expectedData = $inpuData;
@@ -195,6 +196,7 @@ public function wrongValueTypesProvider()
             [['email_body' => 666]],
             [['email_from_name' => 666]],
             [['email_from_address' => 666]],
+            [['external_id' => 666]],
         ];
     }