Add missing "long", "lat", "country" body parameters for devices endp…

…oint
norkunas · Apr 19, 2018 · 7725e7a · 7725e7a
1 parent 41dbd9a
commit 7725e7a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/Resolver/DeviceResolver.php b/src/Resolver/DeviceResolver.php
@@ -69,6 +69,12 @@ public function resolve(array $data)
             ->setDefined('test_type')
             ->setAllowedTypes('test_type', 'int')
             ->setAllowedValues('test_type', [1, 2])
+            ->setDefined('long')
+            ->setAllowedTypes('long', 'double')
+            ->setDefined('lat')
+            ->setAllowedTypes('lat', 'double')
+            ->setDefined('country')
+            ->setAllowedTypes('country', 'string')
             ->setDefault('app_id', $this->config->getApplicationId())
             ->setAllowedTypes('app_id', 'string');
 
@@ -88,6 +94,8 @@ public function resolve(array $data)
                     Devices::SAFARI,
                     Devices::FIREFOX,
                     Devices::MACOS,
+                    Devices::ALEXA,
+                    Devices::EMAIL,
                 ]);
         }
 

diff --git a/tests/OneSignal/Tests/Resolver/DeviceResolverTest.php b/tests/OneSignal/Tests/Resolver/DeviceResolverTest.php
@@ -40,6 +40,9 @@ public function testResolveWithValidValues()
             'last_active' => 98,
             'notification_types' => -2,
             'test_type' => 1,
+            'long' => 55.1684595,
+            'lat' => 22.7624291,
+            'country' => 'LT',
             'app_id' => 'value',
         ];
 
@@ -100,6 +103,9 @@ public function wrongValueTypesProvider()
             [['last_active' => 'wrongType']],
             [['notification_types' => 'wrongType']],
             [['test_type' => 'wrongType']],
+            [['long' => true]],
+            [['lat' => true]],
+            [['country' => false]],
             [['app_id' => 666]],
             [['device_type' => 666]],
         ];