Add email notification parameters on resolver (#90)

* Add email notification parameters on resolver Add email notification support * Add optional datas (email_from_address, email_from_name) to email notification * add unit test to new email notification var
norkunas · Apr 11, 2018 · 6832f3d · 6832f3d
1 parent 696da61
commit 6832f3d
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/src/Resolver/NotificationResolver.php b/src/Resolver/NotificationResolver.php
@@ -193,6 +193,14 @@ public function resolve(array $data)
             ->setAllowedTypes('priority', 'int')
             ->setDefault('app_id', $this->config->getApplicationId())
             ->setAllowedTypes('app_id', 'string')
+            ->setDefined('email_subject')
+            ->setAllowedTypes('email_subject', 'string')
+            ->setDefined('email_body')
+            ->setAllowedTypes('email_body', 'string')
+            ->setDefined('email_from_name')
+            ->setAllowedTypes('email_from_name', 'string')
+            ->setDefined('email_from_address')
+            ->setAllowedTypes('email_from_address', 'string')
             ->resolve($data);
     }
 

diff --git a/tests/OneSignal/Tests/Resolver/NotificationResolverTest.php b/tests/OneSignal/Tests/Resolver/NotificationResolverTest.php
@@ -103,6 +103,10 @@ public function testResolveWithValidValues()
             'ttl' => 23,
             'priority' => 10,
             'app_id' => 'value',
+            'email_subject' => 'value',
+            'email_body' => 'value',
+            'email_from_name' => 'value',
+            'email_from_address' => 'value',
         ];
 
         $expectedData = $inpuData;
@@ -186,6 +190,10 @@ public function wrongValueTypesProvider()
             [['ttl' => 'wrongType']],
             [['priority' => 'wrongType']],
             [['app_id' => 666]],
+            [['email_subject' => 666]],
+            [['email_body' => 666]],
+            [['email_from_name' => 666]],
+            [['email_from_address' => 666]],
         ];
     }