Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use args.This() in zlib #56988

Merged
merged 1 commit into from
Feb 11, 2025
Merged

src: use args.This() in zlib #56988

merged 1 commit into from
Feb 11, 2025

Conversation

targos
Copy link
Member

@targos targos commented Feb 10, 2025

Refs: #53474

@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 10, 2025
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib subsystem. labels Feb 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

@targos targos added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 10, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 10, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65121/

@codecov Codecov
Copy link

codecov bot commented Feb 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.14%. Comparing base (6ba36b4) to head (8fff518).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/node_zlib.cc 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56988      +/-   ##
==========================================
- Coverage   89.14%   89.14%   -0.01%     
==========================================
  Files         665      665              
  Lines      193174   193174              
  Branches    37189    37188       -1     
==========================================
- Hits       172202   172197       -5     
- Misses      13735    13750      +15     
+ Partials     7237     7227      -10
Files with missing lines Coverage Δ
src/node_zlib.cc 78.47% <0.00%> (+0.09%) ⬆️

... and 39 files with indirect coverage changes

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65132/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65135/

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 11, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 11, 2025
@nodejs-github-bot nodejs-github-bot merged commit 3186468 into nodejs:main Feb 11, 2025
78 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 3186468

targos added a commit that referenced this pull request Feb 11, 2025
@targos
src: use args.This() in zlib
cfea53e 
Refs: #53474
PR-URL: #56988
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@github-actions github-actions bot mentioned this pull request Feb 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@anonrig anonrig anonrig approved these changes

@cjihrig cjihrig cjihrig approved these changes

@juanarbol juanarbol juanarbol approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@targos @nodejs-github-bot @jasnell @anonrig @cjihrig @juanarbol @marco-ippolito