Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zlib: make all zstd functions experimental #56964

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Feb 8, 2025

Original PR didn't make these functions experimental. Let's make it, before we know the API surface is stable.

Ref: #52100

cc @jkrems

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. zlib Issues and PRs related to the zlib subsystem. labels Feb 8, 2025
Copy link
Contributor

@jkrems jkrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good point!

@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 8, 2025
@lpinca
Copy link
Member

lpinca commented Feb 8, 2025

I would replace zlib: with doc: in commit title.

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 10, 2025
@nodejs-github-bot nodejs-github-bot merged commit 92dae7d into nodejs:main Feb 10, 2025
30 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 92dae7d

targos pushed a commit that referenced this pull request Feb 11, 2025
PR-URL: #56964
Refs: #52100
Reviewed-By: Jan Krems <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants