Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update zlib to 1.3.0.1-motley-788cb3c #56655

Merged
merged 1 commit into from
Feb 9, 2025
Merged

deps: update zlib to 1.3.0.1-motley-788cb3c #56655

merged 1 commit into from
Feb 9, 2025
+828 −158

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Jan 19, 2025 •
edited
Loading

This is an automated update of zlib to 1.3.0.1-motley-788cb3c.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. zlib Issues and PRs related to the zlib subsystem. labels Jan 19, 2025
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 19, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.13%. Comparing base (b181535) to head (376cfa7).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56655      +/-   ##
==========================================
- Coverage   89.13%   89.13%   -0.01%     
==========================================
  Files         665      665              
  Lines      193165   193165              
  Branches    37191    37186       -5     
==========================================
- Hits       172181   172176       -5     
- Misses      13729    13736       +7     
+ Partials     7255     7253       -2

see 35 files with indirect coverage changes

@lpinca
Copy link
Member

lpinca commented Jan 19, 2025

Changes are not relevant, we can skip this.

@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-zlib branch from 369d53c to 35618f4 Compare January 26, 2025 00:31
@targos targos force-pushed the actions/tools-update-zlib branch from 35618f4 to 779754b Compare January 29, 2025 09:33
@targos
Copy link
Member

targos commented Jan 29, 2025

Rebased to fix the test failure.

@targos targos added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jan 29, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 29, 2025
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/64823/

@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-zlib branch from 779754b to 2f04a79 Compare February 2, 2025 00:32
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 5, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 5, 2025
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/65001/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/65045/

@nodejs-github-bot nodejs-github-bot changed the title deps: update zlib to 1.3.0.1-motley-5634698 deps: update zlib to 1.3.0.1-motley-788cb3c Feb 9, 2025
@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-zlib branch from 2f04a79 to 376cfa7 Compare February 9, 2025 00:33
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 9, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 9, 2025
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/65080/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/65082/

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 9, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 9, 2025
@nodejs-github-bot nodejs-github-bot merged commit 5e6092b into main Feb 9, 2025
57 checks passed
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 5e6092b

@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-zlib branch February 9, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nodejs-github-bot @lpinca @targos @jasnell @RafaelGSS @marco-ippolito