v18.3.0 proposal

.github/CODEOWNERS

@@ -107,10 +107,8 @@
 
 /benchmark/misc/startup.js @nodejs/startup
 /src/node.cc @nodejs/startup
-/src/node_code_cache_stub.cc @nodejs/startup
 /src/node_native_module* @nodejs/startup
 /lib/internal/bootstrap/* @nodejs/startup
-/tools/code_cache/* @nodejs/startup
 /tools/snapshot/* @nodejs/startup
 
 # V8

.github/label-pr-config.yml

@@ -67,7 +67,7 @@ subSystemLabels:
   /^tools\/make-v8/: tools, v8 engine, needs-ci
   /^tools\/v8_gypfiles/: tools, v8 engine, needs-ci
   /^tools\/(code_cache|snapshot)/: needs-ci
-  /^tools\/build-addons.js/: needs-ci
+  /^tools\/build-addons.mjs/: needs-ci
   # all other tool changes should be marked as such
   /^tools\//: tools
   /^\.eslint|\.remark|\.editorconfig/: tools

.github/workflows/authors.yml

@@ -15,7 +15,7 @@ jobs:
         with:
           fetch-depth: '0'  # This is required to actually get all the authors
           persist-credentials: false
-      - run: tools/update-authors.js  # Run the AUTHORS tool
+      - run: tools/update-authors.mjs  # Run the AUTHORS tool
       - uses: gr2m/create-or-update-pull-request-action@v1  # Create a PR or update the Action's existing PR
         env:
           GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
@@ -24,7 +24,7 @@ jobs:
           body: >
             Here are some new additions to the AUTHORS file.
             This is an automatically generated PR by the
-            `authors.yml` GitHub Action, which runs `tools/update-authors.js`.
+            `authors.yml` GitHub Action, which runs `tools/update-authors.mjs`.
           branch: actions/authors-update  # Custom branch *just* for this Action.
           commit-message: 'meta: update AUTHORS'
           labels: meta

.mailmap

@@ -89,6 +89,8 @@ Charles <[email protected]> <[email protected]>
 Charles Rudolph <[email protected]>
 Chen Gang <[email protected]>
 Chen Gang <[email protected]> <[email protected]>
+Chengzhong Wu <[email protected]>
+Chengzhong Wu <[email protected]> <[email protected]>
 Chew Choon Keat <[email protected]>
 Chris Andrews <[email protected]>
 Chris Johnson <[email protected]>
@@ -357,6 +359,8 @@ Mitar Milutinovic <[email protected]>
 Mithun Sasidharan <[email protected]> <[email protected]>
 Mohammed Keyvanzadeh <[email protected]>
 Mohammed Keyvanzadeh <[email protected]> <[email protected]>
+Morgan Roderick <[email protected]>
+Morgan Roderick <[email protected]> <[email protected]>
 MURAKAMI Masahiko <[email protected]> <[email protected]>
 Myles Borins <[email protected]> <[email protected]>
 Myles Borins <[email protected]> <[email protected]>
@@ -374,13 +378,15 @@ Nitzan Uziely <[email protected]> <[email protected]>
 Nitzan Uziely <[email protected]> <[email protected]>
 Noah Rose Ledesma <[email protected]>
 npm team <[email protected]>
+npm team <[email protected]> <npm CLI robot>
 npm team <[email protected]> <npm team>
 Oliver Chang <[email protected]>
 Oluwaseun Omoyajowo <[email protected]>
 OneNail <[email protected]> <[email protected]>
 Onne Gorter <[email protected]>
 Oscar Martinez <[email protected]> <[email protected]>
 Paolo Insogna <[email protected]>
+Paolo Insogna <[email protected]> <[email protected]>
 Paul Graham <[email protected]> <[email protected]>
 Paul Querna <[email protected]> <[email protected]>
 Pedro Lima <[email protected]>

AUTHORS

@@ -2315,7 +2315,7 @@ Yongsheng Zhang <[email protected]>
 Neeraj Laad <[email protected]>
 Scott Van Gilder <[email protected]>
 Yaniv Friedensohn <[email protected]>
-Lucas Woo <[email protected]>
+Chengzhong Wu <[email protected]>
 Troels Liebe Bentsen <[email protected]>
 pranshuchittora <[email protected]>
 lakamsani <[email protected]>
@@ -3260,7 +3260,6 @@ Siddharth <[email protected]>
 Cactysman <[email protected]>
 David Brownman <[email protected]>
 Michael Rommel <[email protected]>
-Chengzhong Wu <[email protected]>
 Andres <[email protected]>
 Jayden Seric <[email protected]>
 divlo <[email protected]>
@@ -3460,5 +3459,6 @@ Sergey Nazaryev <[email protected]>
 William Marlow <[email protected]>
 Keyhan Vakil <[email protected]>
 Feng Yu <[email protected]>
+pupilTong <[email protected]>
 
-# Generated by tools/update-authors.js
+# Generated by tools/update-authors.mjs

BUILDING.md

@@ -99,25 +99,25 @@ Node.js does not support a platform version if a vendor has expired support
 for it. In other words, Node.js does not support running on End-of-Life (EoL)
 platforms. This is true regardless of entries in the table below.
 
-| Operating System | Architectures    | Versions                          | Support Type                                | Notes                                |
-| ---------------- | ---------------- | --------------------------------- | ------------------------------------------- | ------------------------------------ |
-| GNU/Linux        | x64              | kernel >= 4.18[^1], glibc >= 2.28 | Tier 1                                      | e.g. Ubuntu 20.04, Debian 10, RHEL 8 |
-| GNU/Linux        | x64              | kernel >= 3.10, musl >= 1.1.19    | Experimental                                | e.g. Alpine 3.8                      |
-| GNU/Linux        | x86              | kernel >= 3.10, glibc >= 2.17     | Experimental                                | Downgraded as of Node.js 10          |
-| GNU/Linux        | arm64            | kernel >= 4.18[^1], glibc >= 2.28 | Tier 1                                      | e.g. Ubuntu 20.04, Debian 10, RHEL 8 |
-| GNU/Linux        | armv7            | kernel >= 4.18[^1], glibc >= 2.28 | Tier 1                                      | e.g. Ubuntu 20.04, Debian 10         |
-| GNU/Linux        | armv6            | kernel >= 4.14, glibc >= 2.24     | Experimental                                | Downgraded as of Node.js 12          |
-| GNU/Linux        | ppc64le >=power8 | kernel >= 4.18[^1], glibc >= 2.28 | Tier 2                                      | e.g. Ubuntu 20.04, RHEL 8            |
-| GNU/Linux        | s390x            | kernel >= 4.18[^1], glibc >= 2.28 | Tier 2                                      | e.g. RHEL 8                          |
-| Windows          | x64              | >= Windows 10/Server 2016         | Tier 1                                      | [^2],[^3]                            |
-| Windows          | x86              | >= Windows 10/Server 2016         | Experimental                                | [^4]                                 |
-| Windows          | x64, x86         | Windows 8.1/Server 2012           | Experimental                                |                                      |
-| Windows          | arm64            | >= Windows 10                     | Tier 2 (compiling) / Experimental (running) |                                      |
-| macOS            | x64              | >= 10.15                          | Tier 1                                      | For notes about compilation see [^5] |
-| macOS            | arm64            | >= 11                             | Tier 1                                      |                                      |
-| SmartOS          | x64              | >= 18                             | Tier 2                                      |                                      |
-| AIX              | ppc64be >=power8 | >= 7.2 TL04                       | Tier 2                                      |                                      |
-| FreeBSD          | x64              | >= 12.2                           | Experimental                                |                                      |
+| Operating System | Architectures    | Versions                          | Support Type                                    | Notes                                |
+| ---------------- | ---------------- | --------------------------------- | ----------------------------------------------- | ------------------------------------ |
+| GNU/Linux        | x64              | kernel >= 4.18[^1], glibc >= 2.28 | Tier 1                                          | e.g. Ubuntu 20.04, Debian 10, RHEL 8 |
+| GNU/Linux        | x64              | kernel >= 3.10, musl >= 1.1.19    | Experimental                                    | e.g. Alpine 3.8                      |
+| GNU/Linux        | x86              | kernel >= 3.10, glibc >= 2.17     | Experimental                                    | Downgraded as of Node.js 10          |
+| GNU/Linux        | arm64            | kernel >= 4.18[^1], glibc >= 2.28 | Tier 1                                          | e.g. Ubuntu 20.04, Debian 10, RHEL 8 |
+| GNU/Linux        | armv7            | kernel >= 4.18[^1], glibc >= 2.28 | Tier 1                                          | e.g. Ubuntu 20.04, Debian 10         |
+| GNU/Linux        | armv6            | kernel >= 4.14, glibc >= 2.24     | Experimental                                    | Downgraded as of Node.js 12          |
+| GNU/Linux        | ppc64le >=power8 | kernel >= 4.18[^1], glibc >= 2.28 | Tier 2                                          | e.g. Ubuntu 20.04, RHEL 8            |
+| GNU/Linux        | s390x            | kernel >= 4.18[^1], glibc >= 2.28 | Tier 2                                          | e.g. RHEL 8                          |
+| Windows          | x64, x86 (WoW64) | >= Windows 10/Server 2016         | Tier 1                                          | [^2],[^3]                            |
+| Windows          | x86 (native)     | >= Windows 10/Server 2016         | Tier 1 (running) / Experimental (compiling)[^4] |                                      |
+| Windows          | x64, x86         | Windows 8.1/Server 2012           | Experimental                                    |                                      |
+| Windows          | arm64            | >= Windows 10                     | Tier 2 (compiling) / Experimental (running)     |                                      |
+| macOS            | x64              | >= 10.15                          | Tier 1                                          | For notes about compilation see [^5] |
+| macOS            | arm64            | >= 11                             | Tier 1                                          |                                      |
+| SmartOS          | x64              | >= 18                             | Tier 2                                          |                                      |
+| AIX              | ppc64be >=power8 | >= 7.2 TL04                       | Tier 2                                          |                                      |
+| FreeBSD          | x64              | >= 12.2                           | Experimental                                    |                                      |
 
 [^1]: Older kernel versions may work. However official Node.js release
     binaries are [built on RHEL 8 systems](#official-binary-platforms-and-toolchains)
@@ -137,9 +137,10 @@ platforms. This is true regardless of entries in the table below.
     Windows binary (`node.exe`) in WSL will not work without workarounds such as
     stdio redirection.
 
-[^4]: Compiling Node.js for x86 Windows is currently impossible due to
-    issues with version 10.1 of the V8 engine. Support will come back to its
-    previous status as soon as possible.
+[^4]: Running Node.js on x86 Windows should work and binaries
+    are provided. However, tests in our infrastructure only run on WoW64.
+    Furthermore, compiling on x86 Windows is Experimental and
+    may not be possible.
 
 [^5]: Our macOS x64 Binaries are compiled with 10.15 as a target. Xcode11 is
     required to compile.
@@ -538,7 +539,7 @@ When modifying only the JS layer in `lib`, it is possible to externally load it
 without modifying the executable:
 
 ```console
-$ ./configure --node-builtin-modules-path $(pwd)
+$ ./configure --node-builtin-modules-path "$(pwd)"
 ```
 
 The resulting binary won't include any JS files and will try to load them from

CHANGELOG.md

@@ -35,7 +35,8 @@ release.
 </tr>
 <tr>
   <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V18.md#18.2.0">18.2.0</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V18.md#18.3.0">18.3.0</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V18.md#18.2.0">18.2.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V18.md#18.1.0">18.1.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V18.md#18.0.0">18.0.0</a><br/>
   </td>

Makefile

@@ -366,13 +366,13 @@ ADDONS_BINDING_SOURCES := \
 	$(filter-out test/addons/??_*/*.h, $(wildcard test/addons/*/*.h))
 
 ADDONS_PREREQS := config.gypi \
-	deps/npm/node_modules/node-gyp/package.json tools/build-addons.js \
+	deps/npm/node_modules/node-gyp/package.json tools/build-addons.mjs \
 	deps/uv/include/*.h deps/v8/include/*.h \
 	src/node.h src/node_buffer.h src/node_object_wrap.h src/node_version.h
 
 define run_build_addons
 env npm_config_loglevel=$(LOGLEVEL) npm_config_nodedir="$$PWD" \
-	npm_config_python="$(PYTHON)" $(NODE) "$$PWD/tools/build-addons" \
+	npm_config_python="$(PYTHON)" $(NODE) "$$PWD/tools/build-addons.mjs" \
 	"$$PWD/deps/npm/node_modules/node-gyp/bin/node-gyp.js" \
 	$1
 touch $2
@@ -679,21 +679,21 @@ ifneq ("","$(wildcard deps/v8/tools/run-tests.py)")
 # Related CI job: node-test-commit-v8-linux
 test-v8: v8  ## Runs the V8 test suite on deps/v8.
 	export PATH="$(NO_BIN_OVERRIDE_PATH)" && \
-		deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) $(V8_TEST_OPTIONS) \
+		$(PYTHON) deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) $(V8_TEST_OPTIONS) \
 				mjsunit cctest debugger inspector message preparser \
 				$(TAP_V8)
 	$(info Testing hash seed)
 	$(MAKE) test-hash-seed
 
 test-v8-intl: v8
 	export PATH="$(NO_BIN_OVERRIDE_PATH)" && \
-		deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) \
+		$(PYTHON) deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) \
 				intl \
 				$(TAP_V8_INTL)
 
 test-v8-benchmarks: v8
 	export PATH="$(NO_BIN_OVERRIDE_PATH)" && \
-		deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) \
+		$(PYTHON) deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) \
 				benchmarks \
 				$(TAP_V8_BENCHMARKS)
 

README.md

@@ -683,6 +683,8 @@ Primary GPG keys for Node.js Releasers (some Releasers sign with subkeys):
   `8FCCA13FEF1D0C2E91008E09770F7A9A5AE15600`
 * **Myles Borins** <<[email protected]>>
   `C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8`
+* **RafaelGSS** <<[email protected]>>
+  `890C08DB8579162FEE0DF9DB8BEAB4DFCF555EF4`
 * **Richard Lau** <<[email protected]>>
   `C82FA3AE1CBEDC6BE46B9360C43CEC45C17AB93C`
 * **Rod Vagg** <<[email protected]>>
@@ -706,6 +708,7 @@ gpg --keyserver hkps://keys.openpgp.org --recv-keys 71DCFD284A79C3B38668286BC97E
 gpg --keyserver hkps://keys.openpgp.org --recv-keys 61FC681DFB92A079F1685E77973F295594EC4689
 gpg --keyserver hkps://keys.openpgp.org --recv-keys 8FCCA13FEF1D0C2E91008E09770F7A9A5AE15600
 gpg --keyserver hkps://keys.openpgp.org --recv-keys C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8
+gpg --keyserver hkps://keys.openpgp.org --recv-keys 890C08DB8579162FEE0DF9DB8BEAB4DFCF555EF4
 gpg --keyserver hkps://keys.openpgp.org --recv-keys C82FA3AE1CBEDC6BE46B9360C43CEC45C17AB93C
 gpg --keyserver hkps://keys.openpgp.org --recv-keys DD8F2338BAE7501E3DD5AC78C273792F7D83545D
 gpg --keyserver hkps://keys.openpgp.org --recv-keys A48C2BEE680E841632CD4E44F07496B3EB3C1762

SECURITY.md

@@ -4,7 +4,7 @@
 
 Report security bugs in Node.js via [HackerOne](https://hackerone.com/nodejs).
 
-Your report will be acknowledged within 5 days, and you’ll receive a more
+Your report will be acknowledged within 5 days, and you'll receive a more
 detailed response to your report within 10 days indicating the next steps in
 handling your submission.
 
@@ -49,7 +49,7 @@ Here is the security disclosure policy for Node.js
 
 * This process can take some time, especially when coordination is required
   with maintainers of other projects. Every effort will be made to handle the
-  bug in as timely a manner as possible; however, it’s important that we follow
+  bug in as timely a manner as possible; however, it's important that we follow
   the release process above to ensure that the disclosure is handled in a
   consistent manner.
 

benchmark/error/error.js

@@ -0,0 +1,14 @@
+'use strict';
+
+const common = require('../common.js');
+
+const bench = common.createBenchmark(main, {
+  n: [1e7],
+});
+
+function main({ n }) {
+  bench.start();
+  for (let i = 0; i < n; ++i)
+    new Error('test');
+  bench.end(n);
+}

benchmark/error/node-error.js

@@ -0,0 +1,21 @@
+'use strict';
+
+const common = require('../common');
+
+const bench = common.createBenchmark(main, {
+  n: [1e7],
+}, {
+  flags: ['--expose-internals']
+});
+
+function main({ n }) {
+  const {
+    codes: {
+      ERR_INVALID_STATE,
+    }
+  } = require('internal/errors');
+  bench.start();
+  for (let i = 0; i < n; ++i)
+    new ERR_INVALID_STATE.TypeError('test');
+  bench.end(n);
+}

common.gypi

@@ -36,7 +36,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.13',
+    'v8_embedder_string': '-node.8',
 
     ##### V8 defaults for Node.js #####
 

configure.py

@@ -1249,7 +1249,7 @@ def configure_node(o):
     o['variables']['node_use_node_snapshot'] = b(
       not cross_compiling and not options.shared)
 
-  if options.without_node_code_cache or options.node_builtin_modules_path:
+  if options.without_node_code_cache or options.without_node_snapshot or options.node_builtin_modules_path:
     o['variables']['node_use_node_code_cache'] = 'false'
   else:
     # TODO(refack): fix this when implementing embedded code-cache when cross-compiling.

deps/npm/README.md

@@ -37,6 +37,7 @@ If you're looking to manage multiple versions of **`node`** &/or **`npm`**, cons
 * [**`nodenv`**](https://github.com/nodenv/nodenv)
 * [**`asdf-nodejs`**](https://github.com/asdf-vm/asdf-nodejs)
 * [**`nvm-windows`**](https://github.com/coreybutler/nvm-windows)
+* [**`fnm`**](https://github.com/Schniz/fnm)
 
 ### Usage
 
@@ -49,7 +50,7 @@ npm <command>
 * [**Documentation**](https://docs.npmjs.com/) - Official docs & how-tos for all things **npm**
     * Note: you can also search docs locally with `npm help-search <query>`
 * [**Bug Tracker**](https://github.com/npm/cli/issues) - Search or submit bugs against the CLI
-* [**Roadmap**](https://github.com/npm/roadmap) - Track & follow along with our public roadmap
+* [**Roadmap**](https://github.com/orgs/github/projects/4247/views/1?filterQuery=npm) - Track & follow along with our public roadmap
 * [**Feedback**](https://github.com/npm/feedback) - Contribute ideas & discussion around the npm registry, website & CLI
 * [**RFCs**](https://github.com/npm/rfcs) - Contribute ideas & specifications for the API/design of the npm CLI
 * [**Service Status**](https://status.npmjs.org/) - Monitor the current status & see incident reports for the website & registry

deps/npm/docs/content/commands/npm-bin.md

@@ -34,6 +34,8 @@ Print the folder where npm will install executables.
 
 * Default: false
 * Type: Boolean
+* DEPRECATED: `--global`, `--local` are deprecated. Use `--location=global`
+  instead.
 
 Operates in "global" mode, so that packages are installed into the `prefix`
 folder instead of the current working directory. See