Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand testing to cover Python 3.11 #361

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

marbre
Copy link
Collaborator

@marbre marbre commented Oct 29, 2024

Further replaces PurePath.relative_to as the walk_up parameter was added with Python 3.12 and the old behavior defaults to False.

Progress on #357

@marbre marbre requested a review from ScottTodd October 29, 2024 21:25
Comment on lines +41 to +43
strategy:
matrix:
python-version: ["3.11", "3.12"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is anything stopping us from expanding all the way to 3.10 and 3.13 too? Fine to go incrementally too.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests hang on 3.10 (see https://github.com/marbre/SHARK-Platform/actions/runs/11582552347/job/32245832805) and intended to not push a workflow that fails by default ;)

3.13 is already tested in a different workflow with free-threading support but I will add it here as well. However, this should be without free-threading as this feature is requested but seems it was not shipped yet (see actions/setup-python#771).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skip 3.13 in this workflow for now as some pre-build wheels are not available and those fail building without further effort:

ERROR: Failed building wheel for onnx

@marbre marbre changed the title Expand testing to cover Python 3.11 Expand testing to cover Python 3.11 and 3.13 Oct 29, 2024
@marbre marbre force-pushed the shortfin-matrix-python branch from dc9da05 to a5b4f1e Compare October 29, 2024 21:35
@marbre marbre changed the title Expand testing to cover Python 3.11 and 3.13 Expand testing to cover Python 3.11 Oct 29, 2024
@marbre marbre force-pushed the shortfin-matrix-python branch from a5b4f1e to 5210b2f Compare October 29, 2024 21:46
Further replaces `PurePath.relative_to` as the `walk_up` parameter was
added with Python 3.12 and the old behavior defaults to `False`.
@marbre marbre force-pushed the shortfin-matrix-python branch from 5210b2f to 4b64f3c Compare October 29, 2024 23:06
@marbre marbre merged commit d8f39a9 into nod-ai:main Oct 29, 2024
10 checks passed
@marbre marbre deleted the shortfin-matrix-python branch October 29, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants