modules/dash: adaptive DASH + ffmpeg #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As nginx-rtmp is flaky, this replaces it with an ffmpeg command that simultaneously transcodes the stream, and publishes it as DASH and HLS, ensuring it can be watched on most devices.
This allows the load balancer to function properly.
This is a safeguard against a situation encountered during testing, because 1366x768 isn't exactly 16:9, and the ffmpeg dash muxer doesn't like this situation.
This configuration generates 2-second segments, with the keyframe interval set to 2 seconds at 30fps (this is synced up with the incoming OBS stream), and configuring low-latency DASH both here and on the DASH.js client. This brings the latency down from 30 seconds to just over 12 (measured from a text file being rendered by OBS).
alyssais
reviewed
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As nginx-rtmp is flaky, this replaces it with an ffmpeg command that simultaneously transcodes the stream, and publishes it as DASH and HLS, ensuring it can be watched on most devices.