Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins/project-nvim: deprecate #2791

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alisonjenkins
Copy link
Contributor

@alisonjenkins alisonjenkins commented Jan 4, 2025

Deprecate project-nvim as it hasn't been updated in a long time and it's functionality is breaking on recent Neovim versions.

@alisonjenkins alisonjenkins force-pushed the deprecate-project-nvim branch from 1459ef8 to c9e6454 Compare January 4, 2025 21:53
@GaetanLepage GaetanLepage changed the title Deprecate project nvim plugins/project-nvim: deprecate Jan 4, 2025
@GaetanLepage
Copy link
Member

Thanks !
Can you rename the first commit to plugins/project-nvim: deprecate please ?

plugins/deprecation.nix Outdated Show resolved Hide resolved
@khaneliman
Copy link
Contributor

What version does this not work in? I still have this plugin, but haven't used it in a while.

@alisonjenkins alisonjenkins force-pushed the deprecate-project-nvim branch from c9e6454 to 921044a Compare January 4, 2025 22:01
@alisonjenkins
Copy link
Contributor Author

Thanks ! Can you rename the first commit to plugins/project-nvim: deprecate please ?

Done

@alisonjenkins
Copy link
Contributor Author

What version does this not work in? I still have this plugin, but haven't used it in a while.

In both latest Nvim and Nightly. It doesn't seem to add projects anymore. The only way to add the projects is to seek out the file it uses and manually edit it.

Copy link
Member

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alisonjenkins !

@khaneliman
Copy link
Contributor

khaneliman commented Jan 4, 2025

Doesn't seem to be the case for me. New computer and projects are populating fine.
image

Test and test-flake are created yesterday or day before and show up

@alisonjenkins
Copy link
Contributor Author

alisonjenkins commented Jan 4, 2025

Doesn't seem to be the case for me. New computer and projects are populating fine. image

Test and test-flake are created yesterday or day before and show up

Hmm wonder what has broken it on mine then. I used the plugin for years but it hasn't worked on either my new work Mac or my new personal laptop running NixOS. It doesn't add projects on either without me manually editing it so I ended up swapping to telescope-project.

@alisonjenkins
Copy link
Contributor Author

@khaneliman could you see if it works in this for you?

nix run github:alisonjenkins/neovim-nix-flake/9b5846e53627846e19c456993926643349d082fa

This is the last commit of my Nixvim before I removed it in: alisonjenkins/neovim-nix-flake@c5fd2f7

@khaneliman
Copy link
Contributor

khaneliman commented Jan 4, 2025

@khaneliman could you see if it works in this for you?

nix run github:alisonjenkins/neovim-nix-flake/9b5846e53627846e19c456993926643349d082fa

This is the last commit of my Nixvim before I removed it in: alisonjenkins/neovim-nix-flake@c5fd2f7

Yeah, it doesn't generate it from your config but as soon as I entered with mine it did.

nix run github:khaneliman/khanelivim

@alisonjenkins
Copy link
Contributor Author

nix run github:khaneliman/khanelivim

OK let's hold off merging this then and I will see if I can figure out what is breaking this as it could be a problem with something conflicting with it in my config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants