Add 'max_cancel_stream_rate' config for the rapid reset attack #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essen
requested changes
Nov 7, 2023
There was a problem hiding this comment.
Thanks!
There should also be tests similar to http2_reset_flood in security_SUITE except we would have variants of headers+rst_stream sent:
- a test where we send many HEADERS+RST_STREAM immediately
- a test where we send N (10?) HEADERS then N (10?) RST_STREAM, repeatedly
- a test where we send many HEADERS at once and then all RST_STREAM
|
Fixed comments and added a test case. Please look again when you can. |
|
Please rebase onto current master so that CI runs properly. I am planning to do a release with this and other things soon. |
|
Awesome that we have a working CI. Good job! Merge is fine since you'll do a squash-merge anyway, right? Some test runs (but not all) failed in tracer_SUITE. Do you have a clue? |
|
tracer_SUITE on master is a bug in OTP, see erlang/otp#7926 I'd prefer a non-merge rebase but don't worry about it I'll deal with it. |
Co-authored-by: Björn Svensson <[email protected]>
zuiderkwast
force-pushed
the
rapid-reset-attack
branch
from
247b302 to
3511fed
Compare
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1615