Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest .net sdk 8.0.405 #2518

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Update to latest .net sdk 8.0.405 #2518

merged 2 commits into from
Jan 23, 2025

Conversation

rajsite
Copy link
Member

@rajsite rajsite commented Jan 23, 2025

Pull Request

🤨 Rationale

Builds on main started failing with messages like:

/home/runner/work/nimble/nimble/packages/blazor-workspace/Examples/Demo.Client/Demo.Client.csproj : error NU1004: The package reference Microsoft.NET.Sdk.WebAssembly.Pack version has changed from [8.0.11, ) to [8.0.12, ).The packages lock file is inconsistent with the project dependencies so restore can't be run in locked mode. Disable the RestoreLockedMode MSBuild property or pass an explicit --force-evaluate option to run restore to update the lock file. [/home/runner/work/nimble/nimble/packages/blazor-workspace/BlazorWorkspace.sln]

But if you check for references to 8.0.12 assemblies you won't find them. I think what is happening is that the GitHub agents have the latest v8 dotnet installed (v8.0.405) which supersedes the older (v8.0.404) we try to install. So the newer assemblies (v8.0.12) seem to completely replace what the lockfile targets (v8.0.11).

You can reproduce the above errors by just having the newer dotnet sdk (v8.0.405) installed and running a nimble build prior to this PR.

👩‍💻 Implementation

Updated to the latest dotnet sdk and ran npm run update-lock-filesupdate-lock-files.

🧪 Testing

Rely on CI.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@rajsite rajsite changed the title Update to latest .net sdk Update to latest .net sdk 8.0.405 Jan 23, 2025
@rajsite rajsite marked this pull request as ready for review January 23, 2025 15:44
@rajsite rajsite enabled auto-merge (squash) January 23, 2025 16:47
@rajsite rajsite disabled auto-merge January 23, 2025 17:05
@rajsite rajsite merged commit 8e13a3f into main Jan 23, 2025
14 checks passed
@rajsite rajsite deleted the update-dotnet-version branch January 23, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants