[stable30] Empty iceServers.urls handling fix (reloaded) #14291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
According to https://www.w3.org/TR/webrtc/#set-the-configuration browser should throw SyntaxError when starting call with `iceServers` defined with empty `urls`. Talk may call `RTCPeerConnection` with empty `iceServers[0].urls` when no STUN nor TURN servers are configured (tested with HPB) what makes Firefox to throw errors like `RTCPeerConnection constructor passed invalid RTCConfiguration - urls is empty SyntaxError`. With this fix Talk will no longer generate STUN and TURN server settings with empty (or invalid) `urls`. Author-Change-Id: IB#1125985 Signed-off-by: Pawel Boguslawski <[email protected]> Signed-off-by: Daniel Calviño Sánchez <[email protected]>
backportbot
bot
added
3. to review
bug
feature: settings ⚙️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #14289