Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove IS_DESKTOP flag check on generateAbsoluteUrl #14175

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: remove IS_DESKTOP flag check on generateAbsoluteUrl #14175

wants to merge 1 commit into from
+14 −22

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jan 22, 2025

☑️ Resolves

  • With new getBaseUrl there is no need for compile time checking for IS_DESKTOP when generating URL

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@ShGKme ShGKme requested a review from Antreesy January 22, 2025 17:58
@ShGKme ShGKme self-assigned this Jan 22, 2025
@ShGKme ShGKme added this to the 🌿 Next Beta (31) milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Awaiting requested review from Antreesy

At least 1 approving review is required to merge this pull request.

Assignees

@ShGKme ShGKme

Labels
3. to review technical debt
Projects
None yet
Milestone
🌿 Next Beta (31)
Development

Successfully merging this pull request may close these issues.
1 participant
@ShGKme