Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: correctly run stylelint to support unix #14171

Merged
merged 2 commits into from
Jan 22, 2025
Merged

chore: correctly run stylelint to support unix #14171

merged 2 commits into from
Jan 22, 2025

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jan 22, 2025

☑️ Resolves

stylelint css/*.css css/*.scss src/**/*.scss src/**/*.vue

https://stylelint.io/user-guide/cli/

You should include quotation marks around file globs

We didn't, so glob patterns were handled on the shell side instead of stylelint, missing a lot of files on Linux, while it works fine on Windows. (** is not recursive by default)

It must be.

stylelint "css/*.css" "css/*.scss" "src/**/*.scss" "src/**/*.vue"

Also fixed all the stylelint issues.

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme ShGKme added this to the 🌿 Next Beta (31) milestone Jan 22, 2025
@ShGKme ShGKme self-assigned this Jan 22, 2025
@ShGKme ShGKme changed the title chore: correctly tun stylelint to support unix chore: correctly run stylelint to support unix Jan 22, 2025
@Antreesy Antreesy merged commit af08e22 into main Jan 22, 2025
50 checks passed
@Antreesy Antreesy deleted the chore/stylelint branch January 22, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants