Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(transferownership): Allow searching new owner by email #50816

Merged
merged 2 commits into from
Feb 17, 2025
Merged

fix(transferownership): Allow searching new owner by email #50816

merged 2 commits into from
Feb 17, 2025

Conversation

julien-nc
Copy link
Member

Issue

In the transfer ownership personal settings, searching the "new owner" with an email address didn't work. The search request is returning some users but they are not displayed in the NcSelect.

Fix

  • Make the NcSelect non filterable
  • Remove the label prop
  • Add a subname attribute to the options (with user.shareWithDisplayNameUnique as value)

Additional changes

  • Adjust style to have the label on top of the NcSelect
  • Give the NcSelect the same width as the "choose file" button. A larger NcSelect help to see the full title and subline of its option items.

Before

image

After

image

This could be backported to 29, 30 and 31.

@julien-nc julien-nc added this to the Nextcloud 32 milestone Feb 14, 2025
@julien-nc julien-nc requested review from a team and susnux and removed request for a team February 14, 2025 16:31
@julien-nc julien-nc requested a review from skjnldsv as a code owner February 14, 2025 16:31
@julien-nc julien-nc requested review from skjnldsv and Pytal February 14, 2025 16:31
@julien-nc
Copy link
Member Author

/compile

susnux
susnux approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except for disabling local filtering this looks good to me

@julien-nc
fix(transferownership): allow searching by email, display user.shareW…
d8c24b1 
…ithDisplayNameUnique in item subline, adjust style

Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc julien-nc force-pushed the fix/noid/transfer-ownership-select branch from 62d60af to d8c24b1 Compare February 17, 2025 10:31
@julien-nc
Copy link
Member Author

/compile

@julien-nc julien-nc enabled auto-merge February 17, 2025 10:32
@nextcloud-command
chore(assets): Recompile assets
c9545ff 
Signed-off-by: nextcloud-command <[email protected]>
@julien-nc julien-nc merged commit cddcc17 into master Feb 17, 2025
120 checks passed
@julien-nc julien-nc deleted the fix/noid/transfer-ownership-select branch February 17, 2025 10:53
@julien-nc
Copy link
Member Author

/backport to stable30

@backportbot backportbot bot mentioned this pull request Feb 17, 2025
Merged
2 tasks
@julien-nc
Copy link
Member Author

/backport to stable29

@julien-nc
Copy link
Member Author

/backport to stable31

@backportbot backportbot bot mentioned this pull request Feb 17, 2025
Merged
2 tasks
@backportbot backportbot bot mentioned this pull request Feb 17, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@kyteinsky kyteinsky kyteinsky approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

@Pytal Pytal Awaiting requested review from Pytal Pytal was automatically assigned from nextcloud/server-frontend

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: files
Projects
None yet
Milestone
Nextcloud 32
Development

Successfully merging this pull request may close these issues.
4 participants
@julien-nc @susnux @kyteinsky @nextcloud-command