Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(login): only show error state on login box if user interacted #50798

Merged
merged 2 commits into from
Feb 17, 2025
Merged

fix(login): only show error state on login box if user interacted #50798

merged 2 commits into from
Feb 17, 2025

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Feb 13, 2025 •
edited
Loading

Summary

The input fields should only marked as invalid visually if the user interacted with them (e.g. entered something or tried to submit them empty).

Screenshots

before after
Screenshot 2025-02-13 at 17-06-42 Anmelden – Nextcloud Screenshot 2025-02-13 at 17-06-31 Anmelden – Nextcloud

Checklist

@susnux susnux added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: authentication labels Feb 13, 2025
@susnux susnux added this to the Nextcloud 32 milestone Feb 13, 2025
@susnux susnux requested review from szaimen, a team, skjnldsv, sorbaugh and Pytal and removed request for a team February 13, 2025 16:08
@susnux
Copy link
Contributor Author

susnux commented Feb 13, 2025

/backport to stable31

@susnux
Copy link
Contributor Author

susnux commented Feb 13, 2025

/backport to stable30

@susnux
Copy link
Contributor Author

susnux commented Feb 13, 2025

/backport to stable29

Pytal
Pytal reviewed Feb 13, 2025
View reviewed changes
Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to upstream this in NcInputField or make it a prop?

szaimen
szaimen approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the screebshot. Thanks for fixing this! :)

@susnux susnux force-pushed the fix/login-error-state branch from 732f894 to 61d9100 Compare February 17, 2025 09:49
@susnux susnux force-pushed the fix/login-error-state branch from 61d9100 to 1138fd3 Compare February 17, 2025 09:52
@susnux susnux enabled auto-merge February 17, 2025 09:52
@susnux susnux merged commit 626e5bd into master Feb 17, 2025
120 checks passed
@susnux susnux deleted the fix/login-error-state branch February 17, 2025 10:59
This was referenced Feb 17, 2025
Merged
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@Pytal Pytal Pytal approved these changes

@szaimen szaimen szaimen approved these changes

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-frontend

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: authentication
Projects
None yet
Milestone
Nextcloud 32
Development

Successfully merging this pull request may close these issues.

Input fields displayed „invalid“ (red border) without form submission
4 participants
@susnux @skjnldsv @Pytal @szaimen