Add Listener for missing db indices

CHANGELOG.md

@@ -5,6 +5,7 @@ The format is mostly based on [Keep a Changelog](https://keepachangelog.com/en/1
 # Unreleased
 ## [25.x.x]
 ### Changed
+- Add DB index for news_feeds.deleted_at (#2526)
 
 ### Fixed
 

appinfo/info.xml

@@ -21,7 +21,7 @@ Create a [feature request](https://github.com/nextcloud/news/discussions/new)
 
 Report a [feed issue](https://github.com/nextcloud/news/discussions/new)
     ]]></description>
-    <version>25.0.0-alpha3</version>
+    <version>25.0.0-alpha4</version>
     <licence>agpl</licence>
     <author>Benjamin Brahmer</author>
     <author>Sean Molenaar</author>

docs/install.md

@@ -123,9 +123,9 @@ Connect to your DB and execute the commands. Don't forget to switch to the right
 For example in mysql: `use nextcloud;`
 
 ```sql
-DROP TABLE oc_news_folders;
-DROP TABLE oc_news_feeds;
 DROP TABLE oc_news_items;
+DROP TABLE oc_news_feeds;
+DROP TABLE oc_news_folders;
 ```
 
 Then we remove the traces in the migrations table.
@@ -149,4 +149,4 @@ DELETE FROM oc_jobs WHERE class='OCA\\News\\Cron\\Updater';
 DELETE FROM oc_jobs WHERE argument='["OCA\\\\News\\\\Cron\\\\Updater","run"]';
 ```
 
-Now nothing is left from News in your nextcloud installation.
+Now nothing is left from News in your Nextcloud installation.

lib/AppInfo/Application.php

@@ -24,6 +24,7 @@
 use OCA\News\Search\FeedSearchProvider;
 use OCA\News\Search\FolderSearchProvider;
 use OCA\News\Search\ItemSearchProvider;
+use OCA\News\Listeners\AddMissingIndicesListener;
 use OCA\News\Utility\Cache;
 
 use OCP\AppFramework\Bootstrap\IBootContext;
@@ -34,6 +35,7 @@
 use OCA\News\Fetcher\FeedFetcher;
 use OCA\News\Fetcher\Fetcher;
 use OCP\User\Events\BeforeUserDeletedEvent;
+use OCP\DB\Events\AddMissingIndicesEvent;
 use Psr\Container\ContainerInterface;
 use Psr\Log\LoggerInterface;
 
@@ -87,6 +89,7 @@ public function register(IRegistrationContext $context): void
 
 
         $context->registerEventListener(BeforeUserDeletedEvent::class, UserDeleteHook::class);
+        $context->registerEventListener(AddMissingIndicesEvent::class, AddMissingIndicesListener::class);
 
         // parameters
         $context->registerParameter('exploreDir', __DIR__ . '/../Explore/feeds');

lib/Listeners/AddMissingIndicesListener.php

@@ -0,0 +1,32 @@
+<?php
+
+/**
+ * Nextcloud - News
+ *
+ * This file is licensed under the Affero General Public License version 3 or
+ * later. See the COPYING file.
+ *
+ * @author    Benjamin Brahmer <[email protected]>
+ * @copyright 2023 Benjamin Brahmer
+ */
+
+ namespace OCA\News\Listeners;
+
+ use OCP\EventDispatcher\Event;
+ use OCP\EventDispatcher\IEventListener;
+ use OCP\DB\Events\AddMissingIndicesEvent;
+
+ /**
+ * @template-implements IEventListener<Event|AddMissingIndicesEvent>
+ */
+class AddMissingIndicesListener implements IEventListener
+{
+    public function handle(Event $event): void
+    {
+        if (!$event instanceof AddMissingIndicesEvent) {
+            return;
+        }
+
+        $event->addMissingIndex('news_feeds', 'news_feeds_deleted_at_index', ['deleted_at']);
+    }
+}

lib/Migration/Version140200Date20200824201413.php

@@ -181,6 +181,8 @@ public function changeSchema(IOutput $output, Closure $schemaClosure, array $opt
 			$table->addIndex(['user_id'], 'news_feeds_user_id_index');
 			$table->addIndex(['folder_id'], 'news_feeds_folder_id_index');
 			$table->addIndex(['url_hash'], 'news_feeds_url_hash_index');
+			//added with news 25.x
+			$table->addIndex(['deleted_at'], 'news_feeds_deleted_at_index');
 		}
 
 		if (!$schema->hasTable('news_items')) {

lib/Migration/Version150004Date20201009183830.php

@@ -72,7 +72,7 @@ public function postSchemaChange(IOutput $output, Closure $schemaClosure, array
 	    $item_name = $this->connection->getQueryBuilder()->getTableName('news_items');
 	    $feed_name = $this->connection->getQueryBuilder()->getTableName('news_feeds');
 
-	    $items_query = "DELETE FROM ${item_name} WHERE ${item_name}.`feed_id` NOT IN (SELECT DISTINCT id FROM ${feed_name})";
+	    $items_query = "DELETE FROM {$item_name} WHERE {$item_name}.`feed_id` NOT IN (SELECT DISTINCT id FROM {$feed_name})";
         $this->connection->executeQuery($items_query);
 	}
 }

lib/Migration/Version150005Date20201009192341.php

@@ -41,13 +41,13 @@ public function preSchemaChange(IOutput $output, Closure $schemaClosure, array $
         $feed_name = $this->connection->getQueryBuilder()->getTableName('news_feeds');
         $folder_name = $this->connection->getQueryBuilder()->getTableName('news_folders');
 
-        $items_query = "DELETE FROM ${feed_name} WHERE ${feed_name}.`folder_id` NOT IN (SELECT DISTINCT id FROM ${folder_name}) AND ${feed_name}.`folder_id` IS NOT NULL";
+        $items_query = "DELETE FROM {$feed_name} WHERE {$feed_name}.`folder_id` NOT IN (SELECT DISTINCT id FROM {$folder_name}) AND {$feed_name}.`folder_id` IS NOT NULL";
         $this->connection->executeQuery($items_query);
 
         $item_name = $this->connection->getQueryBuilder()->getTableName('news_items');
         $feed_name = $this->connection->getQueryBuilder()->getTableName('news_feeds');
 
-        $items_query = "DELETE FROM ${item_name} WHERE ${item_name}.`feed_id` NOT IN (SELECT DISTINCT id FROM ${feed_name})";
+        $items_query = "DELETE FROM {$item_name} WHERE {$item_name}.`feed_id` NOT IN (SELECT DISTINCT id FROM {$feed_name})";
         $this->connection->executeQuery($items_query);
 	}