Skip to content

Commit

Permalink
new lib
Browse files Browse the repository at this point in the history
  • Loading branch information
marinofaggiana committed May 19, 2021
1 parent 63eb19b commit b9407ec
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 12 deletions.
14 changes: 3 additions & 11 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,26 +37,18 @@ branch. Maybe start working on [starter issues](https://github.com/nextcloud/ios

Easy starting points are also reviewing [pull requests](https://github.com/nextcloud/ios/pulls)

### Xcode Project Setup
### Xcode V 12.5 Project Setup

#### Dependencies

After forking a repository you have to build the dependencies. Dependencies are managed with Carthage.
After forking a repository you have to build the dependencies. Dependencies are managed with Carthage version 0.37.0 or later.
Run

```
carthage build --platform ios
carthage update --use-xcframeworks --platform iOS --cache-builds
```
to fetch and compile the dependencies.

#### Carthage XCode 12 issues

Due to issues with carthage and XCode 12, use the following command when building dependencies for XCode 12

```
./wcarthage update --no-use-binaries --platform iOS --cache-builds
```

### Creating Pull requests

#### DCO Signoff
Expand Down
2 changes: 1 addition & 1 deletion iOSClient/Viewer/NCViewerPDF/NCViewerPDFSearch.swift
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
import Foundation
import PDFKit

@objc protocol NCViewerPDFSearchDelegate : class {
@objc protocol NCViewerPDFSearchDelegate : AnyObject {
func searchPdfSelection(_ pdfSelection: PDFSelection)
}

Expand Down

0 comments on commit b9407ec

Please sign in to comment.