Fix rename types in propreties #3740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamza221
added
3. to review
Signed-off-by: hamza mahjoubi <[email protected]>
hamza221
force-pushed
the
Fix/rename-types
branch
from
aa4c005 to
8ef1266
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3740 +/- ##
==========================================
- Coverage 2.13% 0.00% -2.14%
Complexity 261 261
==========================================
Files 113 24 -89
Lines 5191 784 -4407
Branches 1125 0 -1125
==========================================
- Hits 111 0 -111
+ Misses 4960 784 -4176
+ Partials 120 0 -120 ☔ View full report in Codecov by Sentry. |
GretaD
approved these changes
Dec 14, 2023
|
do we need a backport? |
|
It was introduced here #3374 |
|
/backport to stable5.3 |
|
/backport to stable5.4 |
|
/backport to stable5.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3738