Trashbin scrolling #6295
Open
Trashbin scrolling #6295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tobiasKaminsky <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14475.apk |
Codacy393Lint
SpotBugs (new)
SpotBugs (master)
Lint increased!SpotBugs increased! |
JorisBodin
requested changes
Jun 15, 2020
| @@ -159,9 +159,9 @@ public void showFiles(boolean onDeviceOnly) { | |||
| // must be specialized in subclasses | |||
| MainApp.showOnlyFilesOnDevice(onDeviceOnly); | |||
| if (onDeviceOnly) { | |||
| setupToolbar(); | |||
| setupHomeSearchToolbar(true); | |||
| @@ -1190,16 +1191,16 @@ protected void onResume() { | |||
| if (menuItemId == -1) { | |||
| if (MainApp.isOnlyOnDevice()) { | |||
| setDrawerMenuItemChecked(R.id.nav_on_device); | |||
| setupToolbar(); | |||
| setupHomeSearchToolbar(true); | |||
There was a problem hiding this comment.
Why?
With this code it's for all views. With duplication
| setupToolbar(true, false); | ||
| } | ||
|
|
||
| public void setupHomeSearchToolbar(boolean showShortListGroup) { |
There was a problem hiding this comment.
I don't remember doing anything special. It was already implemented, it seems to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6241
TODO