Remove spot bug type DM_BOXED_PRIMITIVE_FOR_COMPARE

[tobiasKaminsky]

Tried to remove it.
Then found out that Long.compare(…) is API 19+.

• Let us see if this is recognized

Signed-off-by: tobiasKaminsky [email protected]

Testing

Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.

unit tests
instrumented tests
UI tests

• Tests written, or not not needed

[nextcloud-android-bot]

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/13906-IT

[nextcloud-android-bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13908.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[nextcloud-android-bot]

Codacy

377

Lint

Type	master	PR
Warnings	94	94
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	68
Internationalization Warnings	9
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	70
Security Warnings	44
Dodgy code Warnings	138
Total	368

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	68
Internationalization Warnings	9
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	75
Security Warnings	44
Dodgy code Warnings	138
Total	373

[nextcloud-android-bot]

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/13908-IT

[tobiasKaminsky]

@ezaquarii
I tested this with API17 and it works, but
https://developer.android.com/reference/java/lang/Long?hl=en#compare(long,%20long)
shows that it was only added in API19.

Also Lint does not complain, but I do not understand why this works…?

[ezaquarii]

I tested this with API17 and it works, but
https://developer.android.com/reference/java/lang/Long?hl=en#compare(long,%20long)
shows that it was only added in API19.

@tobiasKaminsky
Runtime might be lacking this API, but the d8 might be inlining it, so it compares numbers in place without invoking any API at all. One would need to look at the DEX bytecode to be sure.