Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for #3301 #5834

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Test for #3301 #5834

wants to merge 2 commits into from

Conversation

tobiasKaminsky
Copy link
Member

This is just adding debug:
use logcat and grep for ReceiveExternalFilesActivity.
Upon share of files to NC, it should show something like:

2020-04-07 23:27:32.367 15233-15233/com.nextcloud.client D/ReceiveExternalFilesActivity: Received: 2
2020-04-07 23:27:32.455 15233-15233/com.nextcloud.client D/ReceiveExternalFilesActivity: URI: showImage.png
2020-04-07 23:27:32.487 15233-15233/com.nextcloud.client D/ReceiveExternalFilesActivity: URI: test.png

Signed-off-by: tobiasKaminsky [email protected]

Testing

Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.

unit tests
instrumented tests
UI tests

  • Tests written, or not not needed

@nextcloud-android-bot
Copy link
Collaborator

Signed-off-by: tobiasKaminsky <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]>
@ModischFabrications
Copy link

The APK-Link gives a 404, QR-Code is not available either. Is is not available yet? +2h later seems realistic for a build.

@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14342.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

390

Lint

TypemasterPR
Warnings9595
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings65
Internationalization Warnings9
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings75
Security Warnings44
Dodgy code Warnings139
Total372

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings64
Internationalization Warnings9
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings75
Security Warnings44
Dodgy code Warnings139
Total371

SpotBugs increased!

@nextcloud-android-bot
Copy link
Collaborator

stable-IT test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants