Uploads storage manager sync

[ashpieboop]

Fixes #5487

What this PR does:

• Make UploadsStorageManager a singleton
• Make UploadListAdapter observe UploadsStorageManager and refresh on update

Testing

This is a bugfix PR that adds no features, I assume no additional testing is required.

[nextcloud-android-bot]

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12730-IT

[nextcloud-android-bot]

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12731-IT

[tobiasKaminsky]

Observing the whole uploads section of the database doesn't seem to make any difference regarding #5487

So this does not help? Or do I understand it wrong?

[ashpieboop]

If anything directly modifies the database without going through UploadsStorageManager, Observing the database directly is important. However this PR actually fixes the original specific issue with its first 2 commits alone, but that's the Observable solution on UploadsStorageManager "accessors". There is another mechanism, "messages", that is an alternative and I haven't studied it yet, hence the draft.

[ashpieboop]

I found a todo that says the "Message" system is to get rid of in favor of Observables.

Pending build then I'll request reviewing

[nextcloud-android-bot]

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12796-IT

[nextcloud-android-bot]

Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

[nextcloud-android-bot]

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12809-Screenshot

[nextcloud-android-bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12814.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[nextcloud-android-bot]

Codacy

354

Lint

Type	master	PR
Warnings	76	76
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	69
Internationalization Warnings	13
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	77
Security Warnings	45
Dodgy code Warnings	139
Total	383

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	69
Internationalization Warnings	13
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	77
Security Warnings	45
Dodgy code Warnings	139
Total	383

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@5d428fe). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #5488   +/-   ##
=========================================
  Coverage          ?   21.99%           
  Complexity        ?        3           
=========================================
  Files             ?      398           
  Lines             ?    33480           
  Branches          ?     4697           
=========================================
  Hits              ?     7365           
  Misses            ?    24932           
  Partials          ?     1183

Impacted Files	Coverage Δ	Complexity Δ
...c/main/java/com/nextcloud/client/di/AppModule.java	80.76% <ø> (ø)	0 <0> (?)
...ncloud/android/ui/activity/UploadListActivity.java	54.47% <100%> (ø)	0 <0> (?)
...owncloud/android/ui/adapter/UploadListAdapter.java	14.01% <100%> (ø)	0 <0> (?)

[tobiasKaminsky]

@ArisuOngaku I am really sorry for coming back so late :S
Is this still valid, as you say that Observables might get removed?

[ashpieboop]

@ArisuOngaku I am really sorry for coming back so late :S
Is this still valid, as you say that Observables might get removed?

@tobiasKaminsky I think I didn't mean that; my point is that I found a "TODO" comment somewhere that said that:

• We should get rid of the "Message" system
• We should use the "Observable" instead

I believe that this PR is still relevant unless something new came since I originally submitted that PR.

edit: I removed the note in the PR's first message that could cause some unnecessary confusion.