Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-add CONTENT_TYPE_SEARCH #4748

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

re-add CONTENT_TYPE_SEARCH #4748

wants to merge 1 commit into from

Conversation

tobiasKaminsky
Copy link
Member

Successor of #4233

Signed-off-by: tobiasKaminsky [email protected]

@tobiasKaminsky
re-add CONTENT_TYPE_SEARCH
b111182 
Signed-off-by: tobiasKaminsky <[email protected]>
@tobiasKaminsky
Copy link
Member Author

This is currently not yet enabled, question is, if we should? 🤔

@tobiasKaminsky tobiasKaminsky mentioned this pull request Oct 29, 2019
Open
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11454.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

299

Lint

TypemasterPR
Warnings5959
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings69
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings119
Security Warnings44
Dodgy code Warnings138
Total423

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings69
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings119
Security Warnings44
Dodgy code Warnings138
Total423

@AndyScherzinger
Copy link
Member

I don't know what it would be used for. What I find "strange" is that the content type is relevant for the recently added menu item 🤔

@AndyScherzinger AndyScherzinger added 2. developing needs info Waiting for info from user(s). Issues with this label will auto-stale. labels Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2. developing needs info Waiting for info from user(s). Issues with this label will auto-stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobiasKaminsky @nextcloud-android-bot @AndyScherzinger